From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNyVo-0005lA-HF for ath10k@lists.infradead.org; Tue, 07 May 2019 11:43:58 +0000 Received: by mail-ed1-f67.google.com with SMTP id p26so566506edr.2 for ; Tue, 07 May 2019 04:43:55 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v2] ath10k: fix different tx duration output In-Reply-To: References: <1555489045-18070-1-git-send-email-leiwa@codeaurora.org> <87mukprnie.fsf@toke.dk> <298a645b17aac0f5c466f011225533b0@codeaurora.org> <875zrbrb1q.fsf@toke.dk> Date: Tue, 07 May 2019 13:43:52 +0200 Message-ID: <87y33i7amf.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: leiwa@codeaurora.org Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org bGVpd2FAY29kZWF1cm9yYS5vcmcgd3JpdGVzOgoKPiBPbiAyMDE5LTA0LTE4IDE2OjA3LCBUb2tl IEjDuGlsYW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4+IGxlaXdhQGNvZGVhdXJvcmEub3JnIHdyaXRl czoKPj4gCj4+PiBPbiAyMDE5LTA0LTE3IDE3OjI2LCBUb2tlIEjDuGlsYW5kLUrDuHJnZW5zZW4g d3JvdGU6Cj4+Pj4gTGVpIFdhbmcgPGxlaXdhQGNvZGVhdXJvcmEub3JnPiB3cml0ZXM6Cj4+Pj4g Cj4+Pj4+IFRYIGR1cmF0aW9uIG91dHB1dCBvZiB0eF9zdGF0cyBpbiBkZWJ1Z2ZzIGFuZCBzdGF0 aW9uIGR1bXAgaGFkIGJpZwo+Pj4+PiBkaWZmZXJlbmNlIGJlY2F1c2UgdGhleSBnb3QgdHggZHVy YXRpb24gdmFsdWUgZnJvbSBkaWZmZXJlbnQgCj4+Pj4+IHN0YXRpc3RpYwo+Pj4+PiBkYXRhLiBX ZSBzaG91bGQgdXNlIHRoZSBzYW1lIHN0YXRpc3RpYyBkYXRhLgo+Pj4+IAo+Pj4+IFNvIGFyZSB5 b3Ugc3VyZSB5b3UgcGlja2VkIHRoZSBtb3N0IGFjY3VyYXRlIG9uZSBvZiB0aGUgdHdvPyA6KQo+ Pj4+IAo+Pj4+IC1Ub2tlCj4+PiAKPj4+IEhpIFRva2UsCj4+PiAKPj4+IFllcy4KPj4+IE5vdyBm b3IgYXRoMTBrLCB0aGVyZSBhcmUgdHdvIHdheXMgdG8gZ2V0IHR4IGR1cmF0aW9uIG91dHB1dC4K Pj4+IE9uZSBpcyBnb3QgZnJvbSB0eF9zdGF0cyBpbiBkZWJ1Z2ZzIHJlcG9ydGVkIGJ5IGZpcm13 YXJlLiBJdCBpcyBhIAo+Pj4gdG90YWwKPj4+IHZhbHVlIGluY2x1ZGluZyBhbGwgdGhlIGZyYW1l cyB3aGljaCBjcmVhdGVkIGJ5IGhvc3QgYW5kIGZpcm13YXJlIHNlbnQKPj4+IHRvIHRoZSBwZWVy Lgo+Pj4gQW5kIHRoZSBzZWNvbmQgaXMgY2FsY3VsYXRlZCBmcm9tCj4+PiBhdGgxMGtfaHR0X3J4 X3R4X2NvbXBsX2luZCgpLS0+aWVlZTgwMjExX3N0YV9yZWdpc3Rlcl9haXJ0aW1lKCksIGhlcmUK Pj4+IHRoZSB0eCBkdXJhdGlvbiBqdXN0IGluY2x1ZGVzIHRoZSBkYXRhIGZyYW1lcyBzZW50IGZy b20gaG9zdCB0byB0aGUKPj4+IHBlZXIuCj4+IAo+PiBTbyB0aGUgZGlmZmVyZW5jZSBpcyB0aGF0 IHRoZSBmb3JtZXIgaW5jbHVkZXMgY29udHJvbCBmcmFtZXMgYXMgd2VsbD8gCj4+IElzCj4+IHRo YXQgdGhlIG9ubHkgZGlmZmVyZW5jZT8gQW5kIHdoYXQgZXhhY3RseSBpcyBhICJiaWcgZGlmZmVy ZW5jZSIgKGZyb20KPj4gdGhlIGNvbW1pdCBtZXNzYWdlKT8KPj4gCj4gWWVzLGl0IGFkZHMgdGhl IGR1cmF0aW9uIHRpbWUgb2YgcmVjZWl2aW5nIEFDSyBmcmFtZXMuCj4gIEZyb20gbXkgdGVzdCxU WCBmcm9tIEFQIHRvIHN0YXRpb24gd2l0aCBpcGVyZiBVRFAgdGVzdCBpbiAKPiAxMHMsdHhfc3Rh dHMtPnR4X2R1cmF0aW9uOjU0OTY2MjN1cywKPiBhbmQgYW5vdGhlciB2YWx1ZSBpcyAzOTM0MzI3 dXMuCgpIbW0sIHRoYXQncyBxdWl0ZSBhIGJpZyBkaWZmZXJlbmNlLiBJcyB0aGlzIHJlYWxseSBv bmx5IEFDS3MsIG9yIGlzIGl0CmFsc28gYSBxdWVzdGlvbiBvZiB3aGV0aGVyIHJldHJpZXMgYXJl IGFjY291bnRlZD8gSWYgc28sIGl0IG1heSBhY3R1YWxseQpiZSB0aGF0IHdoYXQgd2Ugc2hvdWxk IGRvIGlzIGNoYW5nZSB3aGljaCB2YWx1ZSBpcyBwYXNzZWQgdG8KaWVlZTgwMjExX3N0YV9yZWdp c3Rlcl9haXJ0aW1lKCk/Cgo+Pj4gU28gdGhlIGZpcnN0IHZhbHVlIGlzIHByZWZlcmFibGUgZm9y IHN0YXRpb24gZHVtcC4KPj4gCj4+IEhtbSwgSSdtIG5vdCBzdXJlIGlmIEkgYWdyZWUgd2l0aCB0 aGlzLiBJIHNwZWNpZmljYWxseSBhZGRlZCB0aGUKPj4gdHhfZHVyYXRpb24gdG8gdGhlIHN0YXRp b24gZHVtcCB0byBiZSBhYmxlIHRvIGdldCB0aGUgdmFsdWVzIHVzZWQgYnkgCj4+IHRoZQo+PiBh aXJ0aW1lIHNjaGVkdWxlci4gVGhpcyBicmVha3Mgd2l0aCB0aGlzIHBhdGNoLgo+PiAKPj4gLVRv a2UKPiAgRnJvbSBvdXIgaW50ZXJuYWwgZGlzY3Vzc2luZywgd2Ugd2lsbCByZXZlcnQgdGhpcyBj aGFuZ2UuCgpDb29sLCBidXQgc2VlIGFib3ZlIDopCgotVG9rZQoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79FE5C004C9 for ; Tue, 7 May 2019 11:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 536F6206A3 for ; Tue, 7 May 2019 11:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726452AbfEGLn4 convert rfc822-to-8bit (ORCPT ); Tue, 7 May 2019 07:43:56 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:44734 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726404AbfEGLn4 (ORCPT ); Tue, 7 May 2019 07:43:56 -0400 Received: by mail-ed1-f65.google.com with SMTP id b8so18390883edm.11 for ; Tue, 07 May 2019 04:43:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version:content-transfer-encoding; bh=0kgIETqFDt+tqtqx6uKvzhB6Qv6yCVJRdyuTHvfTidU=; b=XCGxgLj8C2btnNrX1y/E/0cDDREqfQGbzlf2obmNvkFzFP1iFTDaUHV63Qf3uwRJMP G6vqYXHT8tvwjh4USRIy87H8fpQ3fNcQNIKeuuFo+gIQH57TLzNF9tELev2Xi4qTfK0C Kg1ccpVV4x2gCzVSYsx8DocXvrGVSuORS54PMaCkwd/gHqQO93K8otc6fyDGepfJCX5n bdVDIvq7NAlnwuDnmZ76bRzk6PdRU/1St8OVLXFI2uCZL0r25mkbNEEInyqZqK9cDBis E+2WzQX/MFXcL8hN8QgAHNGA/h7hkP8GlaCOXjBNQKFCg1vcnhg9TOs99n1EAO2KlVre ZcaQ== X-Gm-Message-State: APjAAAUAYqxDCQ1XuY3NmSD1F8BWTnNd2XvcQZu5mg9KWMvHNLbWJrMm WgHx3H9AvbDe76tVXfPM1nT2jA== X-Google-Smtp-Source: APXvYqwodIXCnEmMk+cj678f55sRblfeRoVgVWWJHcnptgzsAlbB5kfIHlBTL8fgZtSwhlwexToOkw== X-Received: by 2002:a17:906:6d58:: with SMTP id a24mr11402671ejt.104.1557229434480; Tue, 07 May 2019 04:43:54 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk (alrua-x1.vpn.toke.dk. [2a00:7660:6da:10::2]) by smtp.gmail.com with ESMTPSA id 65sm594134edk.88.2019.05.07.04.43.53 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 04:43:53 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id DFBA71803A4; Tue, 7 May 2019 13:43:52 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: leiwa@codeaurora.org Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH v2] ath10k: fix different tx duration output In-Reply-To: References: <1555489045-18070-1-git-send-email-leiwa@codeaurora.org> <87mukprnie.fsf@toke.dk> <298a645b17aac0f5c466f011225533b0@codeaurora.org> <875zrbrb1q.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Tue, 07 May 2019 13:43:52 +0200 Message-ID: <87y33i7amf.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org leiwa@codeaurora.org writes: > On 2019-04-18 16:07, Toke Høiland-Jørgensen wrote: >> leiwa@codeaurora.org writes: >> >>> On 2019-04-17 17:26, Toke Høiland-Jørgensen wrote: >>>> Lei Wang writes: >>>> >>>>> TX duration output of tx_stats in debugfs and station dump had big >>>>> difference because they got tx duration value from different >>>>> statistic >>>>> data. We should use the same statistic data. >>>> >>>> So are you sure you picked the most accurate one of the two? :) >>>> >>>> -Toke >>> >>> Hi Toke, >>> >>> Yes. >>> Now for ath10k, there are two ways to get tx duration output. >>> One is got from tx_stats in debugfs reported by firmware. It is a >>> total >>> value including all the frames which created by host and firmware sent >>> to the peer. >>> And the second is calculated from >>> ath10k_htt_rx_tx_compl_ind()-->ieee80211_sta_register_airtime(), here >>> the tx duration just includes the data frames sent from host to the >>> peer. >> >> So the difference is that the former includes control frames as well? >> Is >> that the only difference? And what exactly is a "big difference" (from >> the commit message)? >> > Yes,it adds the duration time of receiving ACK frames. > From my test,TX from AP to station with iperf UDP test in > 10s,tx_stats->tx_duration:5496623us, > and another value is 3934327us. Hmm, that's quite a big difference. Is this really only ACKs, or is it also a question of whether retries are accounted? If so, it may actually be that what we should do is change which value is passed to ieee80211_sta_register_airtime()? >>> So the first value is preferable for station dump. >> >> Hmm, I'm not sure if I agree with this. I specifically added the >> tx_duration to the station dump to be able to get the values used by >> the >> airtime scheduler. This breaks with this patch. >> >> -Toke > From our internal discussing, we will revert this change. Cool, but see above :) -Toke