From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:42663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjxR-0000Ch-J8 for qemu-devel@nongnu.org; Tue, 09 Apr 2019 02:10:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDjxQ-0003cj-Ri for qemu-devel@nongnu.org; Tue, 09 Apr 2019 02:10:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36334) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDjxQ-0003bW-JJ for qemu-devel@nongnu.org; Tue, 09 Apr 2019 02:10:08 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DAFC889C45 for ; Tue, 9 Apr 2019 06:10:07 +0000 (UTC) From: Markus Armbruster References: <20190408083627.7479-1-armbru@redhat.com> <20190408083627.7479-15-armbru@redhat.com> <53312567-fb1e-0f9d-f2d1-1adbf584ef21@redhat.com> Date: Tue, 09 Apr 2019 08:10:03 +0200 In-Reply-To: <53312567-fb1e-0f9d-f2d1-1adbf584ef21@redhat.com> (Eric Blake's message of "Mon, 8 Apr 2019 14:04:13 -0500") Message-ID: <87y34jhfpg.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 14/15] char: Make -chardev help print to stdout List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini Eric Blake writes: > On 4/8/19 3:36 AM, Markus Armbruster wrote: >> Command line help explicitly requested by the user should be printed >> to stdout, not stderr. We do elsewhere. Adjust -chardev to match: >> use qemu_printf() instead of error_printf(). Plain printf() would be >> wrong because we need to print to the current monitor for chardev-add >> help". > > Mismatched " Eagle eyes. Will fix, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EF2AC10F0E for ; Tue, 9 Apr 2019 06:11:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEC1920883 for ; Tue, 9 Apr 2019 06:11:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEC1920883 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:36010 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjyZ-00012o-4k for qemu-devel@archiver.kernel.org; Tue, 09 Apr 2019 02:11:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDjxR-0000Ch-J8 for qemu-devel@nongnu.org; Tue, 09 Apr 2019 02:10:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDjxQ-0003cj-Ri for qemu-devel@nongnu.org; Tue, 09 Apr 2019 02:10:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36334) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDjxQ-0003bW-JJ for qemu-devel@nongnu.org; Tue, 09 Apr 2019 02:10:08 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DAFC889C45 for ; Tue, 9 Apr 2019 06:10:07 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-116.ams2.redhat.com [10.36.116.116]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FC505C223; Tue, 9 Apr 2019 06:10:05 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id CE1E71138648; Tue, 9 Apr 2019 08:10:03 +0200 (CEST) From: Markus Armbruster To: Eric Blake References: <20190408083627.7479-1-armbru@redhat.com> <20190408083627.7479-15-armbru@redhat.com> <53312567-fb1e-0f9d-f2d1-1adbf584ef21@redhat.com> Date: Tue, 09 Apr 2019 08:10:03 +0200 In-Reply-To: <53312567-fb1e-0f9d-f2d1-1adbf584ef21@redhat.com> (Eric Blake's message of "Mon, 8 Apr 2019 14:04:13 -0500") Message-ID: <87y34jhfpg.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Tue, 09 Apr 2019 06:10:07 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH 14/15] char: Make -chardev help print to stdout X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190409061003.78XOGMTXsLS-NdPggzEE2ppKjc-u-LR-j8Vq2wkR6S0@z> Eric Blake writes: > On 4/8/19 3:36 AM, Markus Armbruster wrote: >> Command line help explicitly requested by the user should be printed >> to stdout, not stderr. We do elsewhere. Adjust -chardev to match: >> use qemu_printf() instead of error_printf(). Plain printf() would be >> wrong because we need to print to the current monitor for chardev-add >> help". > > Mismatched " Eagle eyes. Will fix, thanks!