From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v2 03/12] drm/i915: Polish skl_is_16gb_dimm() Date: Mon, 04 Mar 2019 20:19:55 +0200 Message-ID: <87y35u33jo.fsf@intel.com> References: <20190225202907.731-4-ville.syrjala@linux.intel.com> <20190226152631.4364-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id D833689D8E for ; Mon, 4 Mar 2019 18:17:53 +0000 (UTC) In-Reply-To: <20190226152631.4364-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyNiBGZWIgMjAxOSwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBQYXNzIHRoZSBkaW1tIHN0cnVjdCB0byBza2xfaXNfMTZnYl9k aW1tKCkgcmF0aGVyIHRoYW4gcGFzc2luZyBlYWNoCj4gdmFsdWUgc2VwYXJhdGVseS4gQW5kIGxl dCdzIHJlcGxhY2UgdGhlIGhhcmRjb2RlZCBzZXQgb2YgdmFsdWVzIHdpdGgKPiBzb21lIHNpbXBs ZSBhcml0aG1ldGljLgo+Cj4gQWxzbyBmaXggdGhlIGJ5dGUgdnMuIGJpdCBpbmNvbnNpc3RlbmN5 IGluIHRoZSBkZWJ1ZyBtZXNzYWdlLAo+IGFuZCBwb2xpc2ggdGhlIHdvcmRpbmcgb3RoZXJ3aXNl IGFzIHdlbGwuCj4KPiB2MjogRGVvYmZ1c2NhdGUgdGhlIG1hdGggKENocmlzKQoKVG9vayBtZSBs b25nZXIgdGhhbiBJJ2QgbGlrZSB0byB3cmFwIG15IGhlYWQgYXJvdW5kIHRoaXMsIGJ1dCBsb29r cwpnb29kLgoKUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ CgoKPgo+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51 eC5pbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCAy OCArKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmggfCAgOCArKysrKy0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMo KyksIDE5IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gaW5kZXggYjk0 YmY0NzViMDRjLi5kODRmMzQ4NWU3NzUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9kcnYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMKPiBA QCAtMTA2OCw2ICsxMDY4LDExIEBAIHN0YXRpYyB2b2lkIGludGVsX3Nhbml0aXplX29wdGlvbnMo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJaW50ZWxfZ3Z0X3Nhbml0aXpl X29wdGlvbnMoZGV2X3ByaXYpOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW50IGludGVsX2RpbW1fbnVt X2RldmljZXMoY29uc3Qgc3RydWN0IGRyYW1fZGltbV9pbmZvICpkaW1tKQo+ICt7Cj4gKwlyZXR1 cm4gZGltbS0+cmFua3MgKiA2NCAvIChkaW1tLT53aWR0aCA/OiAxKTsKPiArfQo+ICsKPiAgc3Rh dGljIGludCBza2xfZ2V0X2RpbW1fc2l6ZSh1MTYgdmFsKQo+ICB7Cj4gIAlyZXR1cm4gdmFsICYg U0tMX0RSQU1fU0laRV9NQVNLOwo+IEBAIC0xMTA3LDE4ICsxMTEyLDEwIEBAIHN0YXRpYyBpbnQg c2tsX2dldF9kaW1tX3JhbmtzKHUxNiB2YWwpCj4gIH0KPiAgCj4gIHN0YXRpYyBib29sCj4gLXNr bF9pc18xNmdiX2RpbW0odTggcmFua3MsIHU4IHNpemUsIHU4IHdpZHRoKQo+ICtza2xfaXNfMTZn Yl9kaW1tKGNvbnN0IHN0cnVjdCBkcmFtX2RpbW1faW5mbyAqZGltbSkKPiAgewo+IC0JaWYgKHJh bmtzID09IDEgJiYgd2lkdGggPT0gOCAmJiBzaXplID09IDE2KQo+IC0JCXJldHVybiB0cnVlOwo+ IC0JZWxzZSBpZiAocmFua3MgPT0gMiAmJiB3aWR0aCA9PSA4ICYmIHNpemUgPT0gMzIpCj4gLQkJ cmV0dXJuIHRydWU7Cj4gLQllbHNlIGlmIChyYW5rcyA9PSAxICYmIHdpZHRoID09IDE2ICYmIHNp emUgPT0gOCkKPiAtCQlyZXR1cm4gdHJ1ZTsKPiAtCWVsc2UgaWYgKHJhbmtzID09IDIgJiYgd2lk dGggPT0gMTYgJiYgc2l6ZSA9PSAxNikKPiAtCQlyZXR1cm4gdHJ1ZTsKPiAtCj4gLQlyZXR1cm4g ZmFsc2U7Cj4gKwkvKiBDb252ZXJ0IHRvdGFsIEdCIHRvIEdiIHBlciBEUkFNIGRldmljZSAqLwo+ ICsJcmV0dXJuIDggKiBkaW1tLT5zaXplIC8gKGludGVsX2RpbW1fbnVtX2RldmljZXMoZGltbSkg PzogMSkgPT0gMTY7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQKPiBAQCAtMTE0OCwxMCArMTE0NSw5 IEBAIHNrbF9kcmFtX2dldF9jaGFubmVsX2luZm8oc3RydWN0IGRyYW1fY2hhbm5lbF9pbmZvICpj aCwgdTMyIHZhbCkKPiAgCWVsc2UKPiAgCQljaC0+cmFua3MgPSAxOwo+ICAKPiAtCWNoLT5pc18x NmdiX2RpbW0gPSBza2xfaXNfMTZnYl9kaW1tKGNoLT5sX2luZm8ucmFua3MsIGNoLT5sX2luZm8u c2l6ZSwKPiAtCQkJCQkgICAgY2gtPmxfaW5mby53aWR0aCkgfHwKPiAtCQkJICAgc2tsX2lzXzE2 Z2JfZGltbShjaC0+c19pbmZvLnJhbmtzLCBjaC0+c19pbmZvLnNpemUsCj4gLQkJCQkJICAgIGNo LT5zX2luZm8ud2lkdGgpOwo+ICsJY2gtPmlzXzE2Z2JfZGltbSA9Cj4gKwkJc2tsX2lzXzE2Z2Jf ZGltbSgmY2gtPmxfaW5mbykgfHwKPiArCQlza2xfaXNfMTZnYl9kaW1tKCZjaC0+c19pbmZvKTsK PiAgCj4gIAlEUk1fREVCVUdfS01TKCIoc2l6ZTp3aWR0aDpyYW5rcykgTCglZEdCOlglZDolZCkg UyglZEdCOlglZDolZClcbiIsCj4gIAkJICAgICAgY2gtPmxfaW5mby5zaXplLCBjaC0+bF9pbmZv LndpZHRoLCBjaC0+bF9pbmZvLnJhbmtzLAo+IEBAIC0xMzY5LDcgKzEzNjUsNyBAQCBpbnRlbF9n ZXRfZHJhbV9pbmZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgCQlzcHJp bnRmKGJhbmR3aWR0aF9zdHIsICJ1bmtub3duIik7Cj4gIAlEUk1fREVCVUdfS01TKCJEUkFNIGJh bmR3aWR0aDolcywgdG90YWwtY2hhbm5lbHM6ICV1XG4iLAo+ICAJCSAgICAgIGJhbmR3aWR0aF9z dHIsIGRyYW1faW5mby0+bnVtX2NoYW5uZWxzKTsKPiAtCURSTV9ERUJVR19LTVMoIkRSQU0gcmFu a3M6ICVkLCAxNkdCLWRpbW06JXNcbiIsCj4gKwlEUk1fREVCVUdfS01TKCJEUkFNIHJhbmtzOiAl ZCwgMTZHYiBESU1NczogJXNcbiIsCj4gIAkJICAgICAgZHJhbV9pbmZvLT5yYW5rcywgeWVzbm8o ZHJhbV9pbmZvLT5pc18xNmdiX2RpbW0pKTsKPiAgfQo+ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPiBpbmRleCBjOWNiMTNhNmVkYWYuLmZjZGUwOTkzNGJiNSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaAo+IEBAIC0yMDY1LDEwICsyMDY1LDEyIEBAIHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlIHsKPiAgCSAqLwo+ICB9Owo+ICAKPiArc3RydWN0IGRyYW1fZGltbV9pbmZvIHsKPiArCXU4 IHNpemUsIHdpZHRoLCByYW5rczsKPiArfTsKPiArCj4gIHN0cnVjdCBkcmFtX2NoYW5uZWxfaW5m byB7Cj4gLQlzdHJ1Y3QgaW5mbyB7Cj4gLQkJdTggc2l6ZSwgd2lkdGgsIHJhbmtzOwo+IC0JfSBs X2luZm8sIHNfaW5mbzsKPiArCXN0cnVjdCBkcmFtX2RpbW1faW5mbyBsX2luZm8sIHNfaW5mbzsK PiAgCXU4IHJhbmtzOwo+ICAJYm9vbCBpc18xNmdiX2RpbW07Cj4gIH07CgotLSAKSmFuaSBOaWt1 bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=