From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 1/9] drm/i915: Make user contexts bannable again! Date: Mon, 18 Feb 2019 12:45:32 +0200 Message-ID: <87y36dxtmb.fsf@gaia.fi.intel.com> References: <20190217161159.815-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20190217161159.815-1-chris@chris-wilson.co.uk> Sender: stable-owner@vger.kernel.org To: intel-gfx@lists.freedesktop.org Cc: Chris Wilson , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org Chris Wilson writes: > Since moving the bannable boolean into the context flags, we lost the > default setting of contexts being bannable. Oops. > > Sadly because we have multi-level banning scheme, our testcase for being > banned cannot distinguish between the expected ban on the context and > the applied banned via the fd. > > Fixes: 6095868a271d ("drm/i915: Complete kerneldoc for struct i915_gem_context") > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: # v4.11+ > --- > drivers/gpu/drm/i915/i915_gem_context.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c > index 280813a4bf82..102866967998 100644 > --- a/drivers/gpu/drm/i915/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/i915_gem_context.c > @@ -364,6 +364,7 @@ __create_hw_context(struct drm_i915_private *dev_priv, > list_add_tail(&ctx->link, &dev_priv->contexts.list); > ctx->i915 = dev_priv; > ctx->sched.priority = I915_USER_PRIORITY(I915_PRIORITY_NORMAL); > + ctx->user_flags = BIT(UCONTEXT_BANNABLE); > But it is there, after setting the ring size. -Mika > for (n = 0; n < ARRAY_SIZE(ctx->__engine); n++) > intel_context_init(&ctx->__engine[n], ctx, dev_priv->engine[n]); > -- > 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9972EC43381 for ; Mon, 18 Feb 2019 10:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71BC22147A for ; Mon, 18 Feb 2019 10:45:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730177AbfBRKpx (ORCPT ); Mon, 18 Feb 2019 05:45:53 -0500 Received: from mga06.intel.com ([134.134.136.31]:2366 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729842AbfBRKpx (ORCPT ); Mon, 18 Feb 2019 05:45:53 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2019 02:45:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,384,1544515200"; d="scan'208";a="134391137" Received: from gaia.fi.intel.com ([10.237.72.169]) by FMSMGA003.fm.intel.com with ESMTP; 18 Feb 2019 02:45:51 -0800 Received: by gaia.fi.intel.com (Postfix, from userid 1000) id EA9E15C060A; Mon, 18 Feb 2019 12:45:32 +0200 (EET) From: Mika Kuoppala To: Chris Wilson , intel-gfx@lists.freedesktop.org Cc: Chris Wilson , stable@vger.kernel.org Subject: Re: [PATCH 1/9] drm/i915: Make user contexts bannable again! In-Reply-To: <20190217161159.815-1-chris@chris-wilson.co.uk> References: <20190217161159.815-1-chris@chris-wilson.co.uk> Date: Mon, 18 Feb 2019 12:45:32 +0200 Message-ID: <87y36dxtmb.fsf@gaia.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Chris Wilson writes: > Since moving the bannable boolean into the context flags, we lost the > default setting of contexts being bannable. Oops. > > Sadly because we have multi-level banning scheme, our testcase for being > banned cannot distinguish between the expected ban on the context and > the applied banned via the fd. > > Fixes: 6095868a271d ("drm/i915: Complete kerneldoc for struct i915_gem_context") > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: # v4.11+ > --- > drivers/gpu/drm/i915/i915_gem_context.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c b/drivers/gpu/drm/i915/i915_gem_context.c > index 280813a4bf82..102866967998 100644 > --- a/drivers/gpu/drm/i915/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/i915_gem_context.c > @@ -364,6 +364,7 @@ __create_hw_context(struct drm_i915_private *dev_priv, > list_add_tail(&ctx->link, &dev_priv->contexts.list); > ctx->i915 = dev_priv; > ctx->sched.priority = I915_USER_PRIORITY(I915_PRIORITY_NORMAL); > + ctx->user_flags = BIT(UCONTEXT_BANNABLE); > But it is there, after setting the ring size. -Mika > for (n = 0; n < ARRAY_SIZE(ctx->__engine); n++) > intel_context_init(&ctx->__engine[n], ctx, dev_priv->engine[n]); > -- > 2.20.1