From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915/icl: Sanitize DDI port clock gating for DSI ports Date: Thu, 29 Nov 2018 16:05:51 +0200 Message-ID: <87y39c7zcw.fsf@intel.com> References: <20181127163606.28841-1-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03B1D6E0FA for ; Thu, 29 Nov 2018 14:05:29 +0000 (UTC) In-Reply-To: <20181127163606.28841-1-imre.deak@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Imre Deak , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCAyNyBOb3YgMjAxOCwgSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPiB3cm90 ZToKPiBUaGUgcmVxdWlyZW1lbnQgZm9yIHRoZSBEREkgcG9ydCBjbG9jayBnYXRpbmcgZm9yIGEg cG9ydCBpbiBEU0kgbW9kZSBpcwo+IHRoZSBvcHBvc2l0ZSB3cnQuIHRoZSBjYXNlIHdoZW4gdGhl IHBvcnQgaXMgaW4gRERJIG1vZGU6IHRoZSBjbG9jawo+IHNob3VsZCBiZSBnYXRlZCB3aGVuIHRo ZSBwb3J0IGlzIGFjdGl2ZSBhbmQgdW5nYXRlZCB3aGVuIHRoZSBwb3J0IGlzCj4gaW5hY3RpdmUu IE5vdGUgdGhhdCB3ZSBjYW5ub3Qgc2ltcGx5IGtlZXAgdGhlIERESSBjbG9jayBnYXRlZCB3aGVu IHRoZQo+IHBvcnQgd2lsbCBiZSBvbmx5IHVzZWQgaW4gRFNJIG1vZGU6IGl0IG11c3QgYmUgZ2F0 ZWQvdW5nYXRlZCBhdCBhCj4gc3BlY2lmaWMgc3BvdCBpbiB0aGUgRFNJIGVuYWJsZS9kaXNhYmxl IHNlcXVlbmNlLgo+Cj4gRW5zdXJlIHRoZSBhYm92ZSBmb3IgYWxsIHBvcnRzIG9mIGEgRFNJIGVu Y29kZXIsIGFsc28gYWRkaW5nIGEgc2FuaXR5Cj4gY2hlY2sgdGhhdCB3ZSBoYXZlbid0IHJlZ2lz dGVyZWQgYW5vdGhlciBlbmNvZGVyIHVzaW5nIHRoZSBzYW1lIHBvcnQKPiAoVkJUIHNob3VsZCBu ZXZlciBhbGxvdyB0aGlzIHRvIGhhcHBlbikuCj4KPiBDYzogTWFkaGF2IENoYXVoYW4gPG1hZGhh di5jaGF1aGFuQGludGVsLmNvbT4KPiBDYzogVmFuZGl0YSBLdWxrYXJuaSA8dmFuZGl0YS5rdWxr YXJuaUBpbnRlbC5jb20+Cj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+ Cj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4g Q2M6IENsaW50IFRheWxvciA8Y2xpbnRvbi5hLnRheWxvckBpbnRlbC5jb20+Cj4gU2lnbmVkLW9m Zi1ieTogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgoKUmV2aWV3ZWQtYnk6IEphbmkg TmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kZGkuYyB8IDY1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHNpLmggfCAgNSArKysrCj4gIDIg ZmlsZXMgY2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kZGkuYwo+IGluZGV4IGFkMTE1NDBhYzQzNi4uNmQwMzJhNmJlMTZjIDEw MDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RkaS5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGRpLmMKPiBAQCAtMjgsNiArMjgsNyBAQAo+ICAjaW5j bHVkZSA8ZHJtL2RybV9zY2RjX2hlbHBlci5oPgo+ICAjaW5jbHVkZSAiaTkxNV9kcnYuaCIKPiAg I2luY2x1ZGUgImludGVsX2Rydi5oIgo+ICsjaW5jbHVkZSAiaW50ZWxfZHNpLmgiCj4gIAo+ICBz dHJ1Y3QgZGRpX2J1Zl90cmFucyB7Cj4gIAl1MzIgdHJhbnMxOwkvKiBiYWxhbmNlIGxlZyBlbmFi bGUsIGRlLWVtcGggbGV2ZWwgKi8KPiBAQCAtMjg1NCw4ICsyODU1LDkgQEAgdm9pZCBpY2xfc2Fu aXRpemVfZW5jb2Rlcl9wbGxfbWFwcGluZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikK PiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShlbmNv ZGVyLT5iYXNlLmRldik7Cj4gIAl1MzIgdmFsOwo+IC0JZW51bSBwb3J0IHBvcnQgPSBlbmNvZGVy LT5wb3J0Owo+IC0JYm9vbCBjbGtfZW5hYmxlZDsKPiArCWVudW0gcG9ydCBwb3J0Owo+ICsJdTMy IHBvcnRfbWFzazsKPiArCWJvb2wgZGRpX2Nsa19uZWVkZWQ7Cj4gIAo+ICAJLyoKPiAgCSAqIElu IGNhc2Ugb2YgRFAgTVNULCB3ZSBzYW5pdGl6ZSB0aGUgcHJpbWFyeSBlbmNvZGVyIG9ubHksIG5v dCB0aGUKPiBAQCAtMjg2NCw5ICsyODY2LDYgQEAgdm9pZCBpY2xfc2FuaXRpemVfZW5jb2Rlcl9w bGxfbWFwcGluZyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikKPiAgCWlmIChlbmNvZGVy LT50eXBlID09IElOVEVMX09VVFBVVF9EUF9NU1QpCj4gIAkJcmV0dXJuOwo+ICAKPiAtCXZhbCA9 IEk5MTVfUkVBRChEUENMS0FfQ0ZHQ1IwX0lDTCk7Cj4gLQljbGtfZW5hYmxlZCA9ICEodmFsICYg aWNsX2RwY2xrYV9jZmdjcjBfY2xrX29mZihkZXZfcHJpdiwgcG9ydCkpOwo+IC0KPiAgCWlmICgh ZW5jb2Rlci0+YmFzZS5jcnRjICYmIGludGVsX2VuY29kZXJfaXNfZHAoZW5jb2RlcikpIHsKPiAg CQl1OCBwaXBlX21hc2s7Cj4gIAkJYm9vbCBpc19tc3Q7Cj4gQEAgLTI4ODAsMjAgKzI4NzksNTIg QEAgdm9pZCBpY2xfc2FuaXRpemVfZW5jb2Rlcl9wbGxfbWFwcGluZyhzdHJ1Y3QgaW50ZWxfZW5j b2RlciAqZW5jb2RlcikKPiAgCQkJcmV0dXJuOwo+ICAJfQo+ICAKPiAtCWlmIChjbGtfZW5hYmxl ZCA9PSAhIWVuY29kZXItPmJhc2UuY3J0YykKPiAtCQlyZXR1cm47Cj4gKwlwb3J0X21hc2sgPSBC SVQoZW5jb2Rlci0+cG9ydCk7Cj4gKwlkZGlfY2xrX25lZWRlZCA9IGVuY29kZXItPmJhc2UuY3J0 YzsKPiAgCj4gLQkvKgo+IC0JICogUHVudCBvbiB0aGUgY2FzZSBub3cgd2hlcmUgY2xvY2sgaXMg ZGlzYWJsZWQsIGJ1dCB0aGUgZW5jb2RlciBpcwo+IC0JICogZW5hYmxlZCwgc29tZXRoaW5nIGVs c2UgaXMgcmVhbGx5IGJyb2tlbiB0aGVuLgo+IC0JICovCj4gLQlpZiAoV0FSTl9PTighY2xrX2Vu YWJsZWQpKQo+IC0JCXJldHVybjsKPiArCWlmIChlbmNvZGVyLT50eXBlID09IElOVEVMX09VVFBV VF9EU0kpIHsKPiArCQlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqb3RoZXJfZW5jb2RlcjsKPiAgCj4g LQlEUk1fTk9URSgiUG9ydCAlYyBpcyBkaXNhYmxlZCBidXQgaXQgaGFzIGEgbWFwcGVkIFBMTCwg dW5tYXAgaXRcbiIsCj4gLQkJIHBvcnRfbmFtZShwb3J0KSk7Cj4gLQl2YWwgfD0gaWNsX2RwY2xr YV9jZmdjcjBfY2xrX29mZihkZXZfcHJpdiwgcG9ydCk7Cj4gLQlJOTE1X1dSSVRFKERQQ0xLQV9D RkdDUjBfSUNMLCB2YWwpOwo+ICsJCXBvcnRfbWFzayA9IGludGVsX2RzaV9lbmNvZGVyX3BvcnRz KGVuY29kZXIpOwo+ICsJCS8qCj4gKwkJICogU2FuaXR5IGNoZWNrIHRoYXQgd2UgaGF2ZW4ndCBp bmNvcnJlY3RseSByZWdpc3RlcmVkIGFub3RoZXIKPiArCQkgKiBlbmNvZGVyIHVzaW5nIGFueSBv ZiB0aGUgcG9ydHMgb2YgdGhpcyBEU0kgZW5jb2Rlci4KPiArCQkgKi8KPiArCQlmb3JfZWFjaF9p bnRlbF9lbmNvZGVyKCZkZXZfcHJpdi0+ZHJtLCBvdGhlcl9lbmNvZGVyKSB7Cj4gKwkJCWlmIChv dGhlcl9lbmNvZGVyID09IGVuY29kZXIpCj4gKwkJCQljb250aW51ZTsKPiArCj4gKwkJCWlmIChX QVJOX09OKHBvcnRfbWFzayAmIEJJVChvdGhlcl9lbmNvZGVyLT5wb3J0KSkpCj4gKwkJCQlyZXR1 cm47Cj4gKwkJfQo+ICsJCS8qCj4gKwkJICogRFNJIHBvcnRzIHNob3VsZCBoYXZlIHRoZWlyIERE SSBjbG9jayB1bmdhdGVkIHdoZW4gZGlzYWJsZWQKPiArCQkgKiBhbmQgZ2F0ZWQgd2hlbiBlbmFi bGVkLgo+ICsJCSAqLwo+ICsJCWRkaV9jbGtfbmVlZGVkID0gIWVuY29kZXItPmJhc2UuY3J0YzsK PiArCX0KPiArCj4gKwl2YWwgPSBJOTE1X1JFQUQoRFBDTEtBX0NGR0NSMF9JQ0wpOwo+ICsJZm9y X2VhY2hfcG9ydF9tYXNrZWQocG9ydCwgcG9ydF9tYXNrKSB7Cj4gKwkJYm9vbCBkZGlfY2xrX3Vu Z2F0ZWQgPSAhKHZhbCAmCj4gKwkJCQkJIGljbF9kcGNsa2FfY2ZnY3IwX2Nsa19vZmYoZGV2X3By aXYsCj4gKwkJCQkJCQkJICAgcG9ydCkpOwo+ICsKPiArCQlpZiAoZGRpX2Nsa19uZWVkZWQgPT0g ZGRpX2Nsa191bmdhdGVkKQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJLyoKPiArCQkgKiBQdW50 IG9uIHRoZSBjYXNlIG5vdyB3aGVyZSBjbG9jayBpcyBnYXRlZCwgYnV0IGl0IHdvdWxkCj4gKwkJ ICogYmUgbmVlZGVkIGJ5IHRoZSBwb3J0LiBTb21ldGhpbmcgZWxzZSBpcyByZWFsbHkgYnJva2Vu IHRoZW4uCj4gKwkJICovCj4gKwkJaWYgKFdBUk5fT04oZGRpX2Nsa19uZWVkZWQpKQo+ICsJCQlj b250aW51ZTsKPiArCj4gKwkJRFJNX05PVEUoIlBvcnQgJWMgaXMgZGlzYWJsZWQvaW4gRFNJIG1v ZGUgd2l0aCBhbiB1bmdhdGVkIERESSBjbG9jaywgZ2F0ZSBpdFxuIiwKPiArCQkJIHBvcnRfbmFt ZShwb3J0KSk7Cj4gKwkJdmFsIHw9IGljbF9kcGNsa2FfY2ZnY3IwX2Nsa19vZmYoZGV2X3ByaXYs IHBvcnQpOwo+ICsJCUk5MTVfV1JJVEUoRFBDTEtBX0NGR0NSMF9JQ0wsIHZhbCk7Cj4gKwl9Cj4g IH0KPiAgCj4gIHN0YXRpYyB2b2lkIGludGVsX2RkaV9jbGtfc2VsZWN0KHN0cnVjdCBpbnRlbF9l bmNvZGVyICplbmNvZGVyLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kc2kuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RzaS5oCj4gaW5kZXggZWU5MzEz N2Y0NDMzLi5kOTY4ZjFmMTNlMDkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZHNpLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kc2kuaAo+IEBA IC0xNDYsNiArMTQ2LDExIEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBpc19jbWRfbW9kZShzdHJ1Y3Qg aW50ZWxfZHNpICppbnRlbF9kc2kpCj4gIAlyZXR1cm4gaW50ZWxfZHNpLT5vcGVyYXRpb25fbW9k ZSA9PSBJTlRFTF9EU0lfQ09NTUFORF9NT0RFOwo+ICB9Cj4gIAo+ICtzdGF0aWMgaW5saW5lIHUx NiBpbnRlbF9kc2lfZW5jb2Rlcl9wb3J0cyhzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcikK PiArewo+ICsJcmV0dXJuIGVuY190b19pbnRlbF9kc2koJmVuY29kZXItPmJhc2UpLT5wb3J0czsK PiArfQo+ICsKPiAgLyogaW50ZWxfZHNpLmMgKi8KPiAgaW50IGludGVsX2RzaV9iaXRyYXRlKGNv bnN0IHN0cnVjdCBpbnRlbF9kc2kgKmludGVsX2RzaSk7Cj4gIGludCBpbnRlbF9kc2lfdGxweF9u cyhjb25zdCBzdHJ1Y3QgaW50ZWxfZHNpICppbnRlbF9kc2kpOwoKLS0gCkphbmkgTmlrdWxhLCBJ bnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==