From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] Add RGBA64 texture cpp for vc4 driver. Date: Thu, 01 Nov 2018 13:10:55 -0700 Message-ID: <87y3ac7e40.fsf@anholt.net> References: <20181101044227.5517-1-nick.kreeger@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2097570522==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FAC66E499 for ; Thu, 1 Nov 2018 20:10:59 +0000 (UTC) In-Reply-To: <20181101044227.5517-1-nick.kreeger@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Nick Kreeger List-Id: dri-devel@lists.freedesktop.org --===============2097570522== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Nick Kreeger writes: > This patch is needed to help implement half-float texturing and > rendering for the vc4 driver in mesa. This small patch introduces the > cpp value for the RGBA64 texture. A future patch will include updates to > vc4_render_cl.c to handle HDR color stores. We'll need a GET_PARAM ioctl param to say "we support RGBA64 textures" and use that from vc4_screen.c's format checking, otherwise new Mesa on old kernels will try to expose RGBA64 textures and fail at rendering time. If we're introducing a GET_PARAM, we probably want to just do half float rendering and texturing at the same time. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlvbXdAACgkQtdYpNtH8 nuip8A//cfPi0YMkHnX4fX2D1V450EM9iqtNWNxlkz/1MuO6VA0TgSH1o6hX+iIE iBv7PD5GQt2kwLSTIRSOuwiGYZOsvuDCUB+XKiuBQSHd9k//cwjjKINPRuTW8ccG VEVxqHHM9YJ7/a8rWKumEoOWKSDnzkD/9tG5K7Cv75HrhH7lwO1gIesxEaB7DvIz cidnBoK1SNinzA9wNvGlPrQxpnAianpWFq2FEPK06WLNt8TcCnnRKKt5H0pXCV/G QExlfsvBTB+vP40ObUv3o/tvafQkjZ0B0+uQd7J0rCdy+4lh0QUFucypckWpEffQ ZCXwatsMvLXED+gnU2h6LOFb9p39ALuH+FwBFzmhdb7XwsRIeMwbshg2Ix18hJg6 /vEeBDhzwfBubspjWDHpJqGOG2OPImNvC4eKCfWwE+Toe8bR6Cv6dX/wnFLYDK06 eorYs1d3yEoP/dZf8YGiUfLTUNLgHq6vH0FFUfiWjwyQU1pGNd4YBSVoAiqNXYiu FHNLPCzpxB8LarMQ0wI68CiffnRibVYbmhXCpvtrJYKJtxSaY80UEvNHfCzMRBeP X07SRRl2Lu//ykQtbuEs2afNPzo9pzIC4DESWvXnKajNOSmkEi4EiMNUUiTZx79M a03p1Ae0LlcDsx74IstsF+RxQa3DD1/hhU4lhRdgeivev6Ap0YA= =trGJ -----END PGP SIGNATURE----- --=-=-=-- --===============2097570522== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============2097570522==--