From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH v3] drm/bochs: add edid support. Date: Tue, 30 Oct 2018 11:28:24 +0200 Message-ID: <87y3afokav.fsf@intel.com> References: <20181029134507.7775-1-kraxel@redhat.com> <87in1kejgj.fsf@intel.com> <20181029200520.jfnmvbkng2er5qbc@sirius.home.kraxel.org> <20181030090632.GJ21967@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id B29D86E1BC for ; Tue, 30 Oct 2018 09:27:36 +0000 (UTC) In-Reply-To: <20181030090632.GJ21967@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Gerd Hoffmann Cc: David Airlie , David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:DRM DRIVER FOR BOCHS VIRTUAL GPU" List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAzMCBPY3QgMjAxOCwgRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPiB3cm90 ZToKPiBPbiBNb24sIE9jdCAyOSwgMjAxOCBhdCAwOTowNToyMFBNICswMTAwLCBHZXJkIEhvZmZt YW5uIHdyb3RlOgo+PiBPbiBNb24sIE9jdCAyOSwgMjAxOCBhdCAwNzo0NDoyOFBNICswMjAwLCBK YW5pIE5pa3VsYSB3cm90ZToKPj4gPiBPbiBNb24sIDI5IE9jdCAyMDE4LCBHZXJkIEhvZmZtYW5u IDxrcmF4ZWxAcmVkaGF0LmNvbT4gd3JvdGU6Cj4+ID4gPiBSZWNlbnQgcWVtdSAobGF0ZXN0IG1h c3RlciBicmFuY2gsIHVwY29taW5nIDMuMSByZWxlYXNlKSBnb3Qgc3VwcG9ydAo+PiA+ID4gZm9y IEVESUQgZGF0YS4gIFRoaXMgcGF0Y2ggYWRkcyBndWVzdCBkcml2ZXIgc3VwcG9ydC4KPj4gPiA+ Cj4+ID4gPiBFRElEIHN1cHBvcnQgaW4gcWVtdSBpcyBub3QgKHlldCkgZW5hYmxlZCBieSBkZWZh dWx0LCBzbyBwbGVhc2UgdXNlCj4+ID4gPiAncWVtdSAtZGV2aWNlIFZHQSxlZGlkPW9uJyBmb3Ig dGVzdGluZy4KPj4gPiAKPj4gPiBBbnkgY2hhbmNlIG9mIG1ha2luZyB0aGlzIHVzZSBkcm1fZ2V0 X2VkaWQoKSAocmVxdWlyZXMgYW4gaTJjX2FkYXB0ZXIpCj4+ID4gb3IgYXQgbGVhc3QgZHJtX2Rv X2dldF9lZGlkKCk/Cj4+IAo+PiBJJ2xsIGhhdmUgYSBsb29rIGF0IHVzaW5nIGRybV9kb19nZXRf ZWRpZCgpLiAgZHJtX2dldF9lZGlkKCkgd2lsbCBub3QKPj4gZmx5IGFzIHRoZXJlIGlzIG5vIGky YyBhZGFwdGVyIGluIHRoZSBmaXJzdCBwbGFjZS4KPgo+IEhtLCBub3Qgc3VyZSB0aGF0IG1ha2Vz IHNlbnNlLiBkcm1fZG9fZ2V0X2VkaWQgaXMgdG8gaGFuZGxlIHRoZSByZWFsLXdvcmxkCj4gZmxh a2luZXNzIG9mIHNpbmtzIChpdCdzIHdoZXJlIGFsbCB0aGUgcmV0cnkgbG9naWMgcmVzaWRlcyks IGlmIHlvdSBkb24ndAo+IGhhdmUgYSBpMmNfYWRhcGF0ZXIgKGJlY2F1c2UgdGhlIGh3IGhhcyBz b21lIG1hZ2ljICJnaXZlIG1lIGFuIGVkaWQiCj4gYmxvY2spLiBGb3IgdmlydHVhbCBodyB3ZSBo b3BlZnVsbHkgZG9uJ3QgcmFuZG9tbHkgZHJvcCBiaXRzIG9uIHRoZSBmbG9vcgo+IGJldHdlZW4g dGhlIGd1ZXN0IGFuZCBob3N0LiBJbW8gdG90YWxseSBmaW5lIGFzLWlzLgo+Cj4gRS5nLiB3ZSBh bHNvIGRvbid0IGZlZWQgdGhlIFZCVCBlZGlkIHRocm91Z2ggZHJtX2RvX2dldF9lZGlkIGVpdGhl ci4KCkJ1dCBub3dhZGF5cyB3ZSBkbyBoYW5kbGUgdGhlIGRlYnVnZnMgRURJRCBvdmVycmlkZSBh bmQgdGhlIEVESUQKZmlybXdhcmUgbG9hZGluZyBpbiBkcm1fZG9fZ2V0X2VkaWQoKSwgc28gdXNp bmcgdGhhdCBnaXZlcyB5b3UgdGhvc2UKZmVhdHVyZXMuCgpCUiwKSmFuaS4KCgotLSAKSmFuaSBO aWt1bGEsIEludGVsIE9wZW4gU291cmNlIEdyYXBoaWNzIENlbnRlcgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F786C2BC61 for ; Tue, 30 Oct 2018 09:27:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2F17120827 for ; Tue, 30 Oct 2018 09:27:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F17120827 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727524AbeJ3SUQ (ORCPT ); Tue, 30 Oct 2018 14:20:16 -0400 Received: from mga11.intel.com ([192.55.52.93]:40858 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbeJ3SUQ (ORCPT ); Tue, 30 Oct 2018 14:20:16 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2018 02:27:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,444,1534834800"; d="scan'208";a="103722239" Received: from jnikula-mobl3.fi.intel.com (HELO localhost) ([10.237.72.61]) by fmsmga001.fm.intel.com with ESMTP; 30 Oct 2018 02:27:33 -0700 From: Jani Nikula To: Daniel Vetter , Gerd Hoffmann Cc: David Airlie , David Airlie , open list , dri-devel@lists.freedesktop.org, "open list\:DRM DRIVER FOR BOCHS VIRTUAL GPU" Subject: Re: [PATCH v3] drm/bochs: add edid support. In-Reply-To: <20181030090632.GJ21967@phenom.ffwll.local> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20181029134507.7775-1-kraxel@redhat.com> <87in1kejgj.fsf@intel.com> <20181029200520.jfnmvbkng2er5qbc@sirius.home.kraxel.org> <20181030090632.GJ21967@phenom.ffwll.local> Date: Tue, 30 Oct 2018 11:28:24 +0200 Message-ID: <87y3afokav.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Oct 2018, Daniel Vetter wrote: > On Mon, Oct 29, 2018 at 09:05:20PM +0100, Gerd Hoffmann wrote: >> On Mon, Oct 29, 2018 at 07:44:28PM +0200, Jani Nikula wrote: >> > On Mon, 29 Oct 2018, Gerd Hoffmann wrote: >> > > Recent qemu (latest master branch, upcoming 3.1 release) got support >> > > for EDID data. This patch adds guest driver support. >> > > >> > > EDID support in qemu is not (yet) enabled by default, so please use >> > > 'qemu -device VGA,edid=on' for testing. >> > >> > Any chance of making this use drm_get_edid() (requires an i2c_adapter) >> > or at least drm_do_get_edid()? >> >> I'll have a look at using drm_do_get_edid(). drm_get_edid() will not >> fly as there is no i2c adapter in the first place. > > Hm, not sure that makes sense. drm_do_get_edid is to handle the real-world > flakiness of sinks (it's where all the retry logic resides), if you don't > have a i2c_adapater (because the hw has some magic "give me an edid" > block). For virtual hw we hopefully don't randomly drop bits on the floor > between the guest and host. Imo totally fine as-is. > > E.g. we also don't feed the VBT edid through drm_do_get_edid either. But nowadays we do handle the debugfs EDID override and the EDID firmware loading in drm_do_get_edid(), so using that gives you those features. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center