Re: [igt-dev] [PATCH v4 06/13] fb: Add more formats

From: Eric Anholt <eric@anholt.net>
To: Maxime Ripard <maxime.ripard@bootlin.com>, igt-dev@lists.freedesktop.org
Cc: eben@raspberrypi.org, Maxime Ripard <maxime.ripard@bootlin.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [igt-dev] [PATCH v4 06/13] fb: Add more formats
Date: Thu, 09 Aug 2018 14:25:48 -0700	[thread overview]
Message-ID: <87y3dfs04j.fsf@anholt.net> (raw)
In-Reply-To: <1e358ab42ddaedf5460560c68df2b61cb6ecd611.1532596850.git-series.maxime.ripard@bootlin.com>

[-- Attachment #1.1: Type: text/plain, Size: 874 bytes --]

Maxime Ripard <maxime.ripard@bootlin.com> writes:

> We're going to need some DRM formats, and we're going to need the igt_fb
> code to handle them. Since it relies on the format_desc structure to map
> the DRM fourcc to the pixman and cairo formats, we need to add these new
> formats to that structure.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  lib/igt_fb.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 9defbd8b044c..17deeada5beb 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -72,16 +72,46 @@ static struct format_desc_struct {
>  	int num_planes;
>  	int plane_bpp[4];
>  } format_desc[] = {
> +	{ .name = "ARGB1555", .depth = 15, .drm_id = DRM_FORMAT_ARGB1555,

.depth=16 here?

Other than that, 1-6 are:

Reviewed-by: Eric Anholt <eric@anholt.net>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev