From: Esben Haabendal <esben.haabendal@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-i2c@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Phil Reid <preid@electromag.com.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lucas Stach <l.stach@pengutronix.de>,
Clemens Gruber <clemens.gruber@pqgruber.com>,
Michail Georgios Etairidis <m.etairidis@beck-ipc.com>,
linux-kernel@vger.kernel.org, Yuan Yao <yao.yuan@freescale.com>,
linux-imx@nxp.com
Subject: Re: [PATCH 1/4] i2c: imx: Fix reinit_completion() use
Date: Mon, 09 Jul 2018 11:20:16 +0200 [thread overview]
Message-ID: <87y3ekahpr.fsf@gmail.com> (raw)
In-Reply-To: <20180704070342.pgnjjffk34nkloob@pengutronix.de> ("Uwe Kleine-König"'s message of "Wed, 4 Jul 2018 09:03:42 +0200")
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
> Cc += Yuan Yao who authored DMA support and the NXP team.
>
> On Wed, May 23, 2018 at 11:56:20AM +0200, Esben Haabendal wrote:
>> From: Esben Haabendal <eha@deif.com>
>>
>> Make sure to call reinit_completion() before dma is started to avoid race
>> condition where reinit_compleition() is called after complete() and before
>
> s/compleition/completion/
Will fix in v2.
>
>> wait_for_completion_timeout().
>
> Is this a theoretical problem, or did it trigger on your side?
I thought I did trigger it, but haven't been able to reproduce.
So it might or might not be theoretical based on my experiences, but it
does look like something that can (and thus should) trigger sometimes.
/Esben
next prev parent reply other threads:[~2018-07-09 9:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 9:56 [PATCH 0/4] i2c: imx: Fix and enable DMA support for LS1021A Esben Haabendal
2018-05-23 9:56 ` [PATCH 1/4] i2c: imx: Fix reinit_completion() use Esben Haabendal
2018-07-04 7:03 ` Uwe Kleine-König
2018-07-09 9:20 ` Esben Haabendal [this message]
2018-05-23 9:56 ` [PATCH 2/4] i2c: imx: Fix race condition in dma read Esben Haabendal
2018-07-05 6:32 ` Uwe Kleine-König
2018-07-09 9:22 ` Esben Haabendal
2018-05-23 9:56 ` [PATCH 3/4] i2c: imx: Simplify stopped state tracking Esben Haabendal
2018-05-23 9:56 ` [PATCH 4/4] arm: dts: ls1021a: Enable I2C DMA support Esben Haabendal
2018-06-15 8:22 ` [PATCH 0/4] i2c: imx: Fix and enable DMA support for LS1021A Esben Haabendal
2018-07-03 21:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3ekahpr.fsf@gmail.com \
--to=esben.haabendal@gmail.com \
--cc=clemens.gruber@pqgruber.com \
--cc=l.stach@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.etairidis@beck-ipc.com \
--cc=p.zabel@pengutronix.de \
--cc=preid@electromag.com.au \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wsa+renesas@sang-engineering.com \
--cc=yao.yuan@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.