From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Armbruster Subject: Re: [Qemu-devel] [PATCH 4/8] xen: Remove useless casts Date: Thu, 05 Jul 2018 07:39:03 +0200 Message-ID: <87y3eqckco.fsf@dusky.pond.sub.org> References: <20180704153919.12432-1-f4bug@amsat.org> <20180704153919.12432-5-f4bug@amsat.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from all-amaz-eas1.inumbo.com ([34.197.232.57]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1fawyw-0007MO-Ky for xen-devel@lists.xenproject.org; Thu, 05 Jul 2018 05:39:06 +0000 In-Reply-To: <20180704153919.12432-5-f4bug@amsat.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 4 Jul 2018 12:39:15 -0300") List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Stefano Stabellini , qemu-devel@nongnu.org, Laurent Vivier , "open list:X86" , Anthony Perard , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau List-Id: xen-devel@lists.xenproject.org UGhpbGlwcGUgTWF0aGlldS1EYXVkw6kgPGY0YnVnQGFtc2F0Lm9yZz4gd3JpdGVzOgoKPiBQYXRj aCBjcmVhdGVkIG1lY2hhbmljYWxseSBieSByZXJ1bm5pbmc6Cj4KPiAgICQgIHNwYXRjaCAtLXNw LWZpbGUgc2NyaXB0cy9jb2NjaW5lbGxlL3R5cGVjYXN0LmNvY2NpIFwKPiAgICAgICAgICAgICAt LW1hY3JvLWZpbGUgc2NyaXB0cy9jb2NjaS1tYWNyby1maWxlLmggXAo+ICAgICAgICAgICAgIC0t ZGlyIC4gLS1pbi1wbGFjZQo+Cj4gU2lnbmVkLW9mZi1ieTogUGhpbGlwcGUgTWF0aGlldS1EYXVk w6kgPGY0YnVnQGFtc2F0Lm9yZz4KPiAtLS0KPiAgaHcveGVuL3hlbl9wdF9jb25maWdfaW5pdC5j IHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkK Pgo+IGRpZmYgLS1naXQgYS9ody94ZW4veGVuX3B0X2NvbmZpZ19pbml0LmMgYi9ody94ZW4veGVu X3B0X2NvbmZpZ19pbml0LmMKPiBpbmRleCBhZWUzMWM2MmJiLi41NWE4MzMzM2YyIDEwMDY0NAo+ IC0tLSBhL2h3L3hlbi94ZW5fcHRfY29uZmlnX2luaXQuYwo+ICsrKyBiL2h3L3hlbi94ZW5fcHRf Y29uZmlnX2luaXQuYwo+IEBAIC01NDMsNyArNTQzLDcgQEAgc3RhdGljIGludCB4ZW5fcHRfZXhw X3JvbV9iYXJfcmVnX3dyaXRlKFhlblBDSVBhc3N0aHJvdWdoU3RhdGUgKnMsCj4gIHsKPiAgICAg IFhlblBUUmVnSW5mbyAqcmVnID0gY2ZnX2VudHJ5LT5yZWc7Cj4gICAgICBYZW5QVFJlZ2lvbiAq YmFzZSA9IE5VTEw7Cj4gLSAgICBQQ0lEZXZpY2UgKmQgPSAoUENJRGV2aWNlICopJnMtPmRldjsK PiArICAgIFBDSURldmljZSAqZCA9ICZzLT5kZXY7Cj4gICAgICB1aW50MzJfdCB3cml0YWJsZV9t YXNrID0gMDsKPiAgICAgIHVpbnQzMl90IHRocm91Z2hhYmxlX21hc2sgPSBnZXRfdGhyb3VnaGFi bGVfbWFzayhzLCByZWcsIHZhbGlkX21hc2spOwo+ICAgICAgcGNpYnVzX3Qgcl9zaXplID0gMDsK ClJldmlld2VkLWJ5OiBNYXJrdXMgQXJtYnJ1c3RlciA8YXJtYnJ1QHJlZGhhdC5jb20+CgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFp bGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpodHRwczovL2xpc3RzLnhl bnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVuLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36540) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fawyw-0008MC-J9 for qemu-devel@nongnu.org; Thu, 05 Jul 2018 01:39:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fawyv-0000Vy-P1 for qemu-devel@nongnu.org; Thu, 05 Jul 2018 01:39:06 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:52476 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fawyv-0000UU-KU for qemu-devel@nongnu.org; Thu, 05 Jul 2018 01:39:05 -0400 From: Markus Armbruster References: <20180704153919.12432-1-f4bug@amsat.org> <20180704153919.12432-5-f4bug@amsat.org> Date: Thu, 05 Jul 2018 07:39:03 +0200 In-Reply-To: <20180704153919.12432-5-f4bug@amsat.org> ("Philippe =?utf-8?Q?Mathieu-Daud=C3=A9=22's?= message of "Wed, 4 Jul 2018 12:39:15 -0300") Message-ID: <87y3eqckco.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 4/8] xen: Remove useless casts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Laurent Vivier , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Anthony Perard , "open list:X86" , Stefano Stabellini , qemu-devel@nongnu.org Philippe Mathieu-Daud=C3=A9 writes: > Patch created mechanically by rerunning: > > $ spatch --sp-file scripts/coccinelle/typecast.cocci \ > --macro-file scripts/cocci-macro-file.h \ > --dir . --in-place > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > hw/xen/xen_pt_config_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c > index aee31c62bb..55a83333f2 100644 > --- a/hw/xen/xen_pt_config_init.c > +++ b/hw/xen/xen_pt_config_init.c > @@ -543,7 +543,7 @@ static int xen_pt_exp_rom_bar_reg_write(XenPCIPassthr= oughState *s, > { > XenPTRegInfo *reg =3D cfg_entry->reg; > XenPTRegion *base =3D NULL; > - PCIDevice *d =3D (PCIDevice *)&s->dev; > + PCIDevice *d =3D &s->dev; > uint32_t writable_mask =3D 0; > uint32_t throughable_mask =3D get_throughable_mask(s, reg, valid_mas= k); > pcibus_t r_size =3D 0; Reviewed-by: Markus Armbruster