From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH] drm/atomic-helper: Use bitwise or for filling a bitmask
Date: Fri, 15 Jun 2018 16:35:55 -0700
Message-ID: <87y3ffk4h0.fsf@anholt.net>
References: <20180615170734.2774-1-ville.syrjala@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1748082337=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id DBD7C6EC4E
 for <dri-devel@lists.freedesktop.org>; Fri, 15 Jun 2018 23:35:57 +0000 (UTC)
In-Reply-To: <20180615170734.2774-1-ville.syrjala@linux.intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

--===============1748082337==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Ville Syrjala <ville.syrjala@linux.intel.com> writes:

> From: Ville Syrj=C3=A4l=C3=A4 <ville.syrjala@linux.intel.com>
>
> Using +=3D to set the bits in a mask looks funny. It works in this case
> because we never set the same bit twice. But let's switch to |=3D to
> make this look more regular.

Reviewed-by: Eric Anholt <eric@anholt.net>

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlskTVsACgkQtdYpNtH8
nugSSQ/+LSye5K1VwwtLz68l4tZGlJXSE4t6pyTuqsoHnosVoJavmMe2lINsQPfI
tdgCn86xP5ptlaVyViAv9QHnrgyBLzgXliKafr26EuQD9pCROL4G7BVTMekwF00D
qR7XqBcuk3aeGVRkZx/gMkiPxEeYa/RlflhLJ7UhaMlxUva61gqloGonFJK9ba6e
P/9KoYPOQgqLokTuxg9kAUP/a6a3M1Iy5U4ZPGZIG7kXNQAvX8P9t26gEfV4/m/T
NRUwXCC+BxHpHwr/h4doWFC7yH5rnvyveebZv5hDVK+5UJURqedc9X+OCpEgMy0U
Ch2FeVFMLupbu8zpVJewFWSTIk01llfWyq6NQsYQzKVi7HxNaVzl8KtSR/sua/FY
n0fJFxR/bx89GRw6dU2d1Z7/BhIg/ewIXs1HdhE/8qExuNdlTpA/Pqt7BvchCAFu
3TZpvJQ4ssK+ML4vXhBvazTAdyqgV2CfOrfB9lrAvaFm+HgkunsYGujsisXU7n8u
BwQwEB4L8mPLoIYGCrFU/gHaqVDUmAAxwb3uRbUgKZ33reGE1OGqgkOcLz15kWvI
/050DbPDbs5Cg25vQ86/LJsPZMO8YrempAIn8qII/DEuDhz2lCx41rhtTLx9cCQf
jlV/pHxpTqTzaxRavzRZCVoGXMYMBz+AuZrLbBdm2rcqAZvklHw=
=64V6
-----END PGP SIGNATURE-----
--=-=-=--

--===============1748082337==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============1748082337==--