From mboxrd@z Thu Jan  1 00:00:00 1970
From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= <toke@toke.dk>
Subject: Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc
Date: Tue, 01 May 2018 23:54:01 +0200
Message-ID: <87y3h311qe.fsf@toke.dk>
References: <20180429213439.7389-1-toke@toke.dk> <CAM_iQpWVrhoo+PjguBLYqwyGyX98Cv3-M=G+CbHrwBom13fwZQ@mail.gmail.com> <CAA93jw6F+c-QRXe+MA2QmRkwiKEBqFgOFKTvWGfO7FvCQ5tFvw@mail.gmail.com> <dff5ba09-1b81-7cd8-4be3-e7a419797d8e@gmail.com> <878t932ont.fsf@toke.dk> <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com> <871sev2mvx.fsf@toke.dk> <c43e3156-dce2-ced7-3a8f-47fe756202f9@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        Cake List <cake@lists.bufferbloat.net>
To: Eric Dumazet <eric.dumazet@gmail.com>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Dave Taht <dave.taht@gmail.com>,
        Cong Wang <xiyou.wangcong@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail.toke.dk ([52.28.52.200]:58259 "EHLO mail.toke.dk"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750780AbeEAVyD (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 1 May 2018 17:54:03 -0400
In-Reply-To: <c43e3156-dce2-ced7-3a8f-47fe756202f9@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Eric Dumazet <eric.dumazet@gmail.com> writes:

> On 05/01/2018 12:31 PM, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>
>> Could you comment on specifically what you believe is broken in this,
>> please, so I can fix it in the same iteration?
>>=20
>
> Apart from the various pskb_may_pull() this helper should not change skb =
layout.
>
> Ideally, the skb should be const and you would use
> skb_header_pointer() to make clear you do not ever write this skb.
>
> This would make the reviewer job pretty easy, as no side effect can
> possibly happen.

Gotcha. Will fix; thanks :)

-Toke