All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	peter.maydell@linaro.org, qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree"
Date: Wed, 18 Apr 2018 08:32:20 +0200	[thread overview]
Message-ID: <87y3hl2fez.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <a23e5774-9a46-7354-3f80-1ad629d102f9@redhat.com> (Paolo Bonzini's message of "Tue, 17 Apr 2018 18:31:08 +0200")

Paolo Bonzini <pbonzini@redhat.com> writes:

> On 17/04/2018 14:18, Igor Mammedov wrote:
>>> What's the point of an object name if it cannot be unique?
>> It should be sufficient for it to be unique within parent's
>> scope and object_property_add_child() should make sure that
>> added object is unique within its parent's namespace.
>> Having named object from starters is useful as object
>> won't have to piggyback on parent (object_get_canonical_path_component)
>> when it need its own name. Then named object could use its name
>> freely anywhere including initfn, property setters/getters and
>> let object_property_add_child() take care of possible name
>> conflict.
>
> I agree that it looks nice, but I'm worried that people forget that the
> path component is only unique until object_unparent().  The use for
> DEVICE_DELETED events is already a bad thing...

Hmm.  If the canonical QOM path isn't the proper way to identify a
device in QMP, what else is?  Honest question!

  reply	other threads:[~2018-04-18  6:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29  3:21 [Qemu-devel] [PATCH qemu] RFC: memory/hmp: Print owners/parents in "info mtree" Alexey Kardashevskiy
2018-04-11 18:57 ` Dr. David Alan Gilbert
2018-04-12  9:15 ` Paolo Bonzini
2018-04-16 13:20   ` Igor Mammedov
2018-04-16 13:30     ` Paolo Bonzini
2018-04-16 14:27       ` Igor Mammedov
2018-04-16 15:29         ` Paolo Bonzini
2018-04-17 12:18           ` Igor Mammedov
2018-04-17 16:31             ` Paolo Bonzini
2018-04-18  6:32               ` Markus Armbruster [this message]
2018-04-18  9:23                 ` Paolo Bonzini
2018-04-19  2:41   ` Alexey Kardashevskiy
2018-04-19 10:33     ` Paolo Bonzini
2018-04-20  6:31       ` Alexey Kardashevskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3hl2fez.fsf@dusky.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=dgilbert@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.