From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH v2] drm/i915/execlists: Delay updating ring register state after resume Date: Wed, 28 Mar 2018 16:40:43 +0300 Message-ID: <87y3ic2u90.fsf@gaia.fi.intel.com> References: <20180327210157.16896-2-chris@chris-wilson.co.uk> <20180327231029.10677-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35F296E1B6 for ; Wed, 28 Mar 2018 13:40:52 +0000 (UTC) In-Reply-To: <20180327231029.10677-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gTm93IHRo YXQgd2UgcmVsb2FkIGJvdGggUklOR19IRUFEIGFuZCBSSU5HX1RBSUwgd2hlbiByZWJpbmRpbmcg dGhlCj4gY29udGV4dCwgd2UgZG8gbm90IG5lZWQgdG8gc2NydWIgdGhvc2UgcmVnaXN0ZXJzIGlt bWVkaWF0ZWx5IG9uIHJlc3VtZS4KPgo+IHYyOiBIYW5kbGUgdGhlIHBlcm1hLXBpbm5lZCBjb250 ZXh0cy4KPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29u LmNvLnVrPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+ IENjOiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMgfCAzMSArKysrKysrKysrKystLS0t LS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxOSBk ZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9s cmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggNjU0NjM0MjU0 YjY0Li4yYmY1MTI4ZWZiMjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfbHJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC0y NTM2LDEzICsyNTM2LDE0IEBAIHN0YXRpYyBpbnQgZXhlY2xpc3RzX2NvbnRleHRfZGVmZXJyZWRf YWxsb2Moc3RydWN0IGk5MTVfZ2VtX2NvbnRleHQgKmN0eCwKPiAgCXJldHVybiByZXQ7Cj4gIH0K PiAgCj4gLXZvaWQgaW50ZWxfbHJfY29udGV4dF9yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2KQo+ICt2b2lkIGludGVsX2xyX2NvbnRleHRfcmVzdW1lKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICppOTE1KQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdp bmU7Cj4gIAlzdHJ1Y3QgaTkxNV9nZW1fY29udGV4dCAqY3R4Owo+ICAJZW51bSBpbnRlbF9lbmdp bmVfaWQgaWQ7Cj4gIAo+IC0JLyogQmVjYXVzZSB3ZSBlbWl0IFdBX1RBSUxfRFdPUkRTIHRoZXJl IG1heSBiZSBhIGRpc3Bhcml0eQo+ICsJLyoKPiArCSAqIEJlY2F1c2Ugd2UgZW1pdCBXQV9UQUlM X0RXT1JEUyB0aGVyZSBtYXkgYmUgYSBkaXNwYXJpdHkKPiAgCSAqIGJldHdlZW4gb3VyIGJvb2tr ZWVwaW5nIGluIGNlLT5yaW5nLT5oZWFkIGFuZCBjZS0+cmluZy0+dGFpbCBhbmQKPiAgCSAqIHRo YXQgc3RvcmVkIGluIGNvbnRleHQuIEFzIHdlIG9ubHkgd3JpdGUgbmV3IGNvbW1hbmRzIGZyb20K PiAgCSAqIGNlLT5yaW5nLT50YWlsIG9ud2FyZHMsIGV2ZXJ5dGhpbmcgYmVmb3JlIHRoYXQgaXMg anVuay4gSWYgdGhlIEdQVQo+IEBAIC0yNTUyLDI3ICsyNTUzLDE5IEBAIHZvaWQgaW50ZWxfbHJf Y29udGV4dF9yZXN1bWUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJICog U28gdG8gYXZvaWQgdGhhdCB3ZSByZXNldCB0aGUgY29udGV4dCBpbWFnZXMgdXBvbiByZXN1bWUu IEZvcgo+ICAJICogc2ltcGxpY2l0eSwgd2UganVzdCB6ZXJvIGV2ZXJ5dGhpbmcgb3V0Lgo+ICAJ ICovCj4gLQlsaXN0X2Zvcl9lYWNoX2VudHJ5KGN0eCwgJmRldl9wcml2LT5jb250ZXh0cy5saXN0 LCBsaW5rKSB7Cj4gLQkJZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgZGV2X3ByaXYsIGlkKSB7Cj4g LQkJCXN0cnVjdCBpbnRlbF9jb250ZXh0ICpjZSA9ICZjdHgtPmVuZ2luZVtlbmdpbmUtPmlkXTsK PiAtCQkJdTMyICpyZWc7Cj4gLQo+IC0JCQlpZiAoIWNlLT5zdGF0ZSkKPiAtCQkJCWNvbnRpbnVl Owo+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeShjdHgsICZpOTE1LT5jb250ZXh0cy5saXN0LCBsaW5r KSB7Cj4gKwkJZm9yX2VhY2hfZW5naW5lKGVuZ2luZSwgaTkxNSwgaWQpIHsKPiArCQkJc3RydWN0 IGludGVsX2NvbnRleHQgKmNlID0gJmN0eC0+ZW5naW5lW2lkXTsKPiAgCj4gLQkJCXJlZyA9IGk5 MTVfZ2VtX29iamVjdF9waW5fbWFwKGNlLT5zdGF0ZS0+b2JqLAo+IC0JCQkJCQkgICAgICBJOTE1 X01BUF9XQik7Cj4gLQkJCWlmIChXQVJOX09OKElTX0VSUihyZWcpKSkKPiArCQkJaWYgKCFjZS0+ cmluZykKPiAgCQkJCWNvbnRpbnVlOwo+ICAKPiAtCQkJcmVnICs9IExSQ19TVEFURV9QTiAqIFBB R0VfU0laRSAvIHNpemVvZigqcmVnKTsKPiAtCQkJcmVnW0NUWF9SSU5HX0hFQUQrMV0gPSAwOwo+ IC0JCQlyZWdbQ1RYX1JJTkdfVEFJTCsxXSA9IDA7Cj4gLQo+IC0JCQljZS0+c3RhdGUtPm9iai0+ bW0uZGlydHkgPSB0cnVlOwo+IC0JCQlpOTE1X2dlbV9vYmplY3RfdW5waW5fbWFwKGNlLT5zdGF0 ZS0+b2JqKTsKPiAtCj4gIAkJCWludGVsX3JpbmdfcmVzZXQoY2UtPnJpbmcsIDApOwo+ICsKPiAr CQkJaWYgKGNlLT5waW5fY291bnQpIHsgLyogb3RoZXJ3aXNlIGRvbmUgaW4gY29udGV4dF9waW4g Ki8KCkZyb20gbXkgdW5kZXJzdGFuZGluZyB0aGlzIGlzIGZvciBrZXJuZWwgY29udGV4dCBvbmx5 LiBTbyB0aGUgY29tbWVudApzaG91bGQgbWVudGlvbiB0aGUga2VybmVsIGNvbnRleHQuCgpSZXZp ZXdlZC1ieTogTWlrYSBLdW9wcGFsYSA8bWlrYS5rdW9wcGFsYUBsaW51eC5pbnRlbC5jb20+Cgo+ ICsJCQkJY2UtPmxyY19yZWdfc3RhdGVbQ1RYX1JJTkdfSEVBRCsxXSA9IDA7Cj4gKwkJCQljZS0+ bHJjX3JlZ19zdGF0ZVtDVFhfUklOR19UQUlMKzFdID0gMDsKPiArCQkJfQo+ICAJCX0KPiAgCX0K PiAgfQo+IC0tIAo+IDIuMTYuMwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK