From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCHv2 6/7] cec-pin-error-inj.rst: document CEC Pin Error Injection Date: Tue, 27 Mar 2018 10:59:13 +0300 Message-ID: <87y3iedk4u.fsf@intel.com> References: <20180305135139.95652-1-hverkuil@xs4all.nl> <20180305135139.95652-7-hverkuil@xs4all.nl> <20180321124511.7e841256@vento.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id EB1B86E57C for ; Tue, 27 Mar 2018 07:58:25 +0000 (UTC) In-Reply-To: <20180321124511.7e841256@vento.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mauro Carvalho Chehab , Hans Verkuil Cc: Maxime Ripard , linux-media@vger.kernel.org, Hans Verkuil , dri-devel@lists.freedesktop.org, Wolfram Sang List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyMSBNYXIgMjAxOCwgTWF1cm8gQ2FydmFsaG8gQ2hlaGFiIDxtY2hlaGFiQHMtb3Bl bnNvdXJjZS5jb20+IHdyb3RlOgo+IFBsZWFzZSBub3RpY2UgdGhhdCBhbGwgZGVidWdmcy9zeXNm cyBlbnRyaWVzIHNob3VsZCAqYWxzbyogYmUKPiBkb2N1bWVudGVkIGF0IHRoZSBzdGFuZGFyZCB3 YXksIGUuIGcuIGJ5IGFkZGluZyB0aGUgY29ycmVzcG9uZGluZwo+IGRvY3VtZW50YXRpb24gYXQg RG9jdW1lbnRhdGlvbi9BQkkuCj4KPiBQbGVhc2Ugc2VlIERvY3VtZW50YXRpb24vQUJJL1JFQURN RS4KPgo+IEFkZGl0aW9uYWxseSwgdGhlcmUgYXJlIGEgZmV3IG1pbm9yIG5pdHBpY2tzIG9uIHRo aXMgcGF0Y2guCj4gU2VlIGJlbG93Lgo+Cj4gVGhlIHJlbWFpbmluZyBwYXRjaGVzIGxvb2tlZCBv ayBvbiBteSBleWVzLgo+Cj4gSSdsbCB3YWl0IGZvciBhIHYzIHdpdGggdGhlIGRlYnVnZnMgQUJJ IGRvY3VtZW50YXRpb24gaW4gb3JkZXIgdG8gbWVyZ2UKPiBpdC4gRmVlbCBmcmVlIHRvIHB1dCBp dCBvbiBhIHNlcGFyYXRlIHBhdGNoLgoKZGVidWdmcyBBQkk/IFNvdW5kcyBsaWtlIGFuIG94eW1v cm9uIHRvIG1lLgoKQlIsCkphbmkuCgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNl IFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga06.intel.com ([134.134.136.31]:44632 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbeC0H6Z (ORCPT ); Tue, 27 Mar 2018 03:58:25 -0400 From: Jani Nikula To: Mauro Carvalho Chehab , Hans Verkuil Cc: Maxime Ripard , Wolfram Sang , Hans Verkuil , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org Subject: Re: [PATCHv2 6/7] cec-pin-error-inj.rst: document CEC Pin Error Injection In-Reply-To: <20180321124511.7e841256@vento.lan> References: <20180305135139.95652-1-hverkuil@xs4all.nl> <20180305135139.95652-7-hverkuil@xs4all.nl> <20180321124511.7e841256@vento.lan> Date: Tue, 27 Mar 2018 10:59:13 +0300 Message-ID: <87y3iedk4u.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, 21 Mar 2018, Mauro Carvalho Chehab wrote: > Please notice that all debugfs/sysfs entries should *also* be > documented at the standard way, e. g. by adding the corresponding > documentation at Documentation/ABI. > > Please see Documentation/ABI/README. > > Additionally, there are a few minor nitpicks on this patch. > See below. > > The remaining patches looked ok on my eyes. > > I'll wait for a v3 with the debugfs ABI documentation in order to merge > it. Feel free to put it on a separate patch. debugfs ABI? Sounds like an oxymoron to me. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center