From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board From: Gregory CLEMENT Message-Id: <87y3l66s0r.fsf@free-electrons.com> Date: Wed, 10 Jan 2018 09:24:04 +0100 To: Chris Packham Cc: jlu@pengutronix.de, linux@armlinux.org.uk, bp@alien8.de, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , devicetree@vger.kernel.org List-ID: SGkgQ2hyaXMsCgogT24gbWFyLiwgamFudi4gMDkgMjAxOCwgQ2hyaXMgUGFja2hhbSA8Y2hyaXMu cGFja2hhbUBhbGxpZWR0ZWxlc2lzLmNvLm56PiB3cm90ZToKCkNvdWxkIHlvdSBoYXZlIGFkZCBh IChldmVuIHNtYWxsKSBtZXNzYWdlIGluIHRoZSBjb21taXQgbG9nPwoKQWxzbyBjb3VsZCB5b3Ug aW1wcm92ZSB0aGUgdGl0bGUgYnkgc3BlY2lmeSB0aGF0IGl0IGFwcGxpZXMgb24KYXJtYWRhLXhw LCBsaWtlIHRoaXM6CgpBUk06IGR0czogYXJtYWRhLXhwOiBlbmFibGUgTDIgY2FjaGUgcGFyaXR5 IGFuZCBlY2Mgb24gZGIteGMzLTI0ZzR4ZwoKCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgUGFja2hh bSA8Y2hyaXMucGFja2hhbUBhbGxpZWR0ZWxlc2lzLmNvLm56Pgo+IC0tLQo+ICBhcmNoL2FybS9i b290L2R0cy9hcm1hZGEteHAtZGIteGMzLTI0ZzR4Zy5kdHMgfCA1ICsrKysrCj4gIDEgZmlsZSBj aGFuZ2VkLCA1IGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9hcmNoL2FybS9ib290L2R0 cy9hcm1hZGEteHAtZGIteGMzLTI0ZzR4Zy5kdHMgYi9hcmNoL2FybS9ib290L2R0cy9hcm1hZGEt eHAtZGIteGMzLTI0ZzR4Zy5kdHMKPiBpbmRleCAwNmZjZTM1ZDc0OTEuLjAwY2E0ODlmYzc4OCAx MDA2NDQKPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9hcm1hZGEteHAtZGIteGMzLTI0ZzR4Zy5k dHMKPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9hcm1hZGEteHAtZGIteGMzLTI0ZzR4Zy5kdHMK PiBAQCAtNzAsNiArNzAsMTEgQEAKPiAgCX07Cj4gIH07Cj4gIAo+ICsmTDIgewo+ICsJYXJtLHBh cml0eS1lbmFibGU7Cj4gKwltYXJ2ZWxsLGVjYy1lbmFibGU7CgpJdCBpcyBub3QgYSBwcm9ibGVt IGZvciBtZSB0byBhbHJlYWR5IGFwcGxpZWQgdGhlIGRldmljZSB0cmVlIGNoYW5nZQpldmVuIGlm IHRoZSBkcml2ZXIgaXMgbm90IG1lcmdlZCB5ZXQuIEJ1dCBJIHdvdWxkIGxpa2UgdG8gaGF2ZSBh bgphY2tlZC1ieSBvbiB0aGlzIG5ldyBwcm9wZXJ0eSBieSBlaXRoZXIgYSBkZXZpY2UgdHJlZSBt YWludGFpbmVyIG9yIGF0CmxlYXN0IHRoZSBFREFDIG1haW50YWluZXIsIG9mIGNvdXJzZSBoYXZp bmcgYm90aCBhY2tlZC1ieSB3b3VsZCBiZQpwZXJmZWN0ICEgOikKClRoYW5rcywKCkdyZWdvcnkK CgoKCj4gK307Cj4gKwo+ICAmZGV2YnVzX2Jvb3RjcyB7Cj4gIAlzdGF0dXMgPSAib2theSI7Cj4g IAo+IC0tIAo+IDIuMTUuMQo+Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 10 Jan 2018 09:24:04 +0100 Subject: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board In-Reply-To: <20180108223158.21930-2-chris.packham@alliedtelesis.co.nz> (Chris Packham's message of "Tue, 9 Jan 2018 11:31:56 +1300") References: <20180108223158.21930-1-chris.packham@alliedtelesis.co.nz> <20180108223158.21930-2-chris.packham@alliedtelesis.co.nz> Message-ID: <87y3l66s0r.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Chris, On mar., janv. 09 2018, Chris Packham wrote: Could you have add a (even small) message in the commit log? Also could you improve the title by specify that it applies on armada-xp, like this: ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg > Signed-off-by: Chris Packham > --- > arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts > index 06fce35d7491..00ca489fc788 100644 > --- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts > +++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts > @@ -70,6 +70,11 @@ > }; > }; > > +&L2 { > + arm,parity-enable; > + marvell,ecc-enable; It is not a problem for me to already applied the device tree change even if the driver is not merged yet. But I would like to have an acked-by on this new property by either a device tree maintainer or at least the EDAC maintainer, of course having both acked-by would be perfect ! :) Thanks, Gregory > +}; > + > &devbus_bootcs { > status = "okay"; > > -- > 2.15.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 1/3] ARM: dts: enable L2 cache parity and ecc on db-xc3-24g4xg board Date: Wed, 10 Jan 2018 09:24:04 +0100 Message-ID: <87y3l66s0r.fsf@free-electrons.com> References: <20180108223158.21930-1-chris.packham@alliedtelesis.co.nz> <20180108223158.21930-2-chris.packham@alliedtelesis.co.nz> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20180108223158.21930-2-chris.packham@alliedtelesis.co.nz> (Chris Packham's message of "Tue, 9 Jan 2018 11:31:56 +1300") Sender: linux-kernel-owner@vger.kernel.org To: Chris Packham Cc: jlu@pengutronix.de, linux@armlinux.org.uk, bp@alien8.de, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Chris, On mar., janv. 09 2018, Chris Packham wrote: Could you have add a (even small) message in the commit log? Also could you improve the title by specify that it applies on armada-xp, like this: ARM: dts: armada-xp: enable L2 cache parity and ecc on db-xc3-24g4xg > Signed-off-by: Chris Packham > --- > arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts > index 06fce35d7491..00ca489fc788 100644 > --- a/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts > +++ b/arch/arm/boot/dts/armada-xp-db-xc3-24g4xg.dts > @@ -70,6 +70,11 @@ > }; > }; > > +&L2 { > + arm,parity-enable; > + marvell,ecc-enable; It is not a problem for me to already applied the device tree change even if the driver is not merged yet. But I would like to have an acked-by on this new property by either a device tree maintainer or at least the EDAC maintainer, of course having both acked-by would be perfect ! :) Thanks, Gregory > +}; > + > &devbus_bootcs { > status = "okay"; > > -- > 2.15.1 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com