From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled Date: Mon, 13 Nov 2017 16:18:01 -0800 Message-ID: <87y3n9af2e.fsf@anholt.net> References: <1510275907-993-1-git-send-email-stschake@gmail.com> <1510275907-993-3-git-send-email-stschake@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0709396517==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id A19736E127 for ; Tue, 14 Nov 2017 00:18:03 +0000 (UTC) In-Reply-To: <1510275907-993-3-git-send-email-stschake@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: David Airlie , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Stefan Schake List-Id: dri-devel@lists.freedesktop.org --===============0709396517== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Stefan Schake writes: > The overflow mem work callback vc4_overflow_mem_work reenables its > associated interrupt upon completion. To ensure all interrupts are disabled > when we return from vc4_irq_uninstall, we need to disable it again if > cancel_work_sync indicated pending work. Is there a reason we need the interrupts disabled at the V3D level while we have the IRQ disabled at the irqchip level? Once we re-enable at the irqchip, we immediately V3D_WRITE(V3D_INTENA, V3D_DRIVER_IRQS) anyway. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAloKNjkACgkQtdYpNtH8 nuh6jw//X125+dW08XNqewZRCJIT9jdyNlLPMc6menW8dhhg8BgBgXsJ418scSiW 1BFKTtDOk3O4x8ov2dCDZHo/eDt+7MtdE/Qlm5dshdStgl5rDAP+dslUuQ+YAvds /wY+l1msNuiT2On5qjXGCcSl6D34u2faulgyg1/DJsfBe0iMI8scLhWwau8m6OwI IupAueGJP/BCb1HEkaWyVT/ITqTSYwztZi/q9p+fVxFOawliZ/Ezna7dGcQV5Syx 0qn6+9utOo4EtV9v3Bs4D6jD9wRdoXWqmGuMdKYaxkJ9yb2flwL2X6DkdDtQxCdw t18tp+TeqzJdbKcikIrveCZHqNnX5Dy4cg8Y30eNwHN6OpQuFryqOCINVXRER2jV joJyNydW4HxwiOgnTK1GShW8YBzXrzNGe3PEGeXoEt35hpWk4IYa9DnncD22d9wD Kv2kMaDnbi3sGRVKDuOf4MmMA6HV2QHGsqi6h4GfKFS/Bz/HRA8qpc4qmZYB7FBF hPeoVcY4vf9XJFpWeV8+PDtlEwDves3cMHMm6x3fTPfQYQH8o1WSBrhBMoaS8y2j weSBTxnM/VEs+YwlteRxgzj96cFAUmvXNWYsktqKE/beAoaprgZzaS4/JM6ounyo wShqzNKdSWtFGCkr1qC/IyXXcXh1BUvMuN15pKHJGajivXHsnOI= =7BbF -----END PGP SIGNATURE----- --=-=-=-- --===============0709396517== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0709396517==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752330AbdKNASF (ORCPT ); Mon, 13 Nov 2017 19:18:05 -0500 Received: from anholt.net ([50.246.234.109]:37606 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbdKNASD (ORCPT ); Mon, 13 Nov 2017 19:18:03 -0500 From: Eric Anholt To: Stefan Schake , dri-devel@lists.freedesktop.org Cc: linux-rpi-kernel@lists.infradead.org, Stefan Schake , David Airlie , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drm/vc4: Ensure interrupts are disabled In-Reply-To: <1510275907-993-3-git-send-email-stschake@gmail.com> References: <1510275907-993-1-git-send-email-stschake@gmail.com> <1510275907-993-3-git-send-email-stschake@gmail.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Mon, 13 Nov 2017 16:18:01 -0800 Message-ID: <87y3n9af2e.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Stefan Schake writes: > The overflow mem work callback vc4_overflow_mem_work reenables its > associated interrupt upon completion. To ensure all interrupts are disabled > when we return from vc4_irq_uninstall, we need to disable it again if > cancel_work_sync indicated pending work. Is there a reason we need the interrupts disabled at the V3D level while we have the IRQ disabled at the irqchip level? Once we re-enable at the irqchip, we immediately V3D_WRITE(V3D_INTENA, V3D_DRIVER_IRQS) anyway. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAloKNjkACgkQtdYpNtH8 nuh6jw//X125+dW08XNqewZRCJIT9jdyNlLPMc6menW8dhhg8BgBgXsJ418scSiW 1BFKTtDOk3O4x8ov2dCDZHo/eDt+7MtdE/Qlm5dshdStgl5rDAP+dslUuQ+YAvds /wY+l1msNuiT2On5qjXGCcSl6D34u2faulgyg1/DJsfBe0iMI8scLhWwau8m6OwI IupAueGJP/BCb1HEkaWyVT/ITqTSYwztZi/q9p+fVxFOawliZ/Ezna7dGcQV5Syx 0qn6+9utOo4EtV9v3Bs4D6jD9wRdoXWqmGuMdKYaxkJ9yb2flwL2X6DkdDtQxCdw t18tp+TeqzJdbKcikIrveCZHqNnX5Dy4cg8Y30eNwHN6OpQuFryqOCINVXRER2jV joJyNydW4HxwiOgnTK1GShW8YBzXrzNGe3PEGeXoEt35hpWk4IYa9DnncD22d9wD Kv2kMaDnbi3sGRVKDuOf4MmMA6HV2QHGsqi6h4GfKFS/Bz/HRA8qpc4qmZYB7FBF hPeoVcY4vf9XJFpWeV8+PDtlEwDves3cMHMm6x3fTPfQYQH8o1WSBrhBMoaS8y2j weSBTxnM/VEs+YwlteRxgzj96cFAUmvXNWYsktqKE/beAoaprgZzaS4/JM6ounyo wShqzNKdSWtFGCkr1qC/IyXXcXh1BUvMuN15pKHJGajivXHsnOI= =7BbF -----END PGP SIGNATURE----- --=-=-=--