From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH] usb: mtu3: fix dma_addr_t printk output again Date: Thu, 02 Nov 2017 17:38:20 +0200 Message-ID: <87y3no8zdf.fsf@linux.intel.com> References: <20171102143027.775184-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20171102143027.775184-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Chunfeng Yun , Greg Kroah-Hartman Cc: Arnd Bergmann , Sudip Mukherjee , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org Hi, Arnd Bergmann writes: > The support for 36-bit addresses originally came with an incorrect > printk format for dma addresses. Felipe changed the format string it > while applying, but the result was still incorrect, since we now have > to pass a pointer to the address instead of the integer value: > > drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_tx_gpd': > drivers/usb/mtu3/mtu3_qmu.c:261:25: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] > drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_rx_gpd': > drivers/usb/mtu3/mtu3_qmu.c:300:25: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] > > This fixes the printk argument accordingly. > > Fixes: 1a46dfea0841 ("usb: mtu3: support 36-bit DMA address") > Signed-off-by: Arnd Bergmann oh, so it wants a pointer afterall :-) sorry. Acked-by: Felipe Balbi -- balbi From mboxrd@z Thu Jan 1 00:00:00 1970 From: felipe.balbi@linux.intel.com (Felipe Balbi) Date: Thu, 02 Nov 2017 17:38:20 +0200 Subject: [PATCH] usb: mtu3: fix dma_addr_t printk output again In-Reply-To: <20171102143027.775184-1-arnd@arndb.de> References: <20171102143027.775184-1-arnd@arndb.de> Message-ID: <87y3no8zdf.fsf@linux.intel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Arnd Bergmann writes: > The support for 36-bit addresses originally came with an incorrect > printk format for dma addresses. Felipe changed the format string it > while applying, but the result was still incorrect, since we now have > to pass a pointer to the address instead of the integer value: > > drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_tx_gpd': > drivers/usb/mtu3/mtu3_qmu.c:261:25: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] > drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_rx_gpd': > drivers/usb/mtu3/mtu3_qmu.c:300:25: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] > > This fixes the printk argument accordingly. > > Fixes: 1a46dfea0841 ("usb: mtu3: support 36-bit DMA address") > Signed-off-by: Arnd Bergmann oh, so it wants a pointer afterall :-) sorry. Acked-by: Felipe Balbi -- balbi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933935AbdKBPin (ORCPT ); Thu, 2 Nov 2017 11:38:43 -0400 Received: from mga03.intel.com ([134.134.136.65]:51397 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933686AbdKBPim (ORCPT ); Thu, 2 Nov 2017 11:38:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,334,1505804400"; d="scan'208";a="168449811" From: Felipe Balbi To: Arnd Bergmann , Chunfeng Yun , Greg Kroah-Hartman Cc: Arnd Bergmann , Sudip Mukherjee , linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: mtu3: fix dma_addr_t printk output again In-Reply-To: <20171102143027.775184-1-arnd@arndb.de> References: <20171102143027.775184-1-arnd@arndb.de> Date: Thu, 02 Nov 2017 17:38:20 +0200 Message-ID: <87y3no8zdf.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Arnd Bergmann writes: > The support for 36-bit addresses originally came with an incorrect > printk format for dma addresses. Felipe changed the format string it > while applying, but the result was still incorrect, since we now have > to pass a pointer to the address instead of the integer value: > > drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_tx_gpd': > drivers/usb/mtu3/mtu3_qmu.c:261:25: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] > drivers/usb/mtu3/mtu3_qmu.c: In function 'mtu3_prepare_rx_gpd': > drivers/usb/mtu3/mtu3_qmu.c:300:25: error: format '%p' expects argument of type 'void *', but argument 7 has type 'dma_addr_t {aka unsigned int}' [-Werror=format=] > > This fixes the printk argument accordingly. > > Fixes: 1a46dfea0841 ("usb: mtu3: support 36-bit DMA address") > Signed-off-by: Arnd Bergmann oh, so it wants a pointer afterall :-) sorry. Acked-by: Felipe Balbi -- balbi