From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keith Packard" Subject: Re: [PATCH 1/2] drm: vblank: use ktime_t instead of timeval Date: Thu, 12 Oct 2017 11:20:02 -0700 Message-ID: <87y3og5iul.fsf@keithp.com> References: <20171011152059.2394516-1-arnd@arndb.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0802822937==" Return-path: Received: from elaine.keithp.com (home.keithp.com [63.227.221.253]) by gabe.freedesktop.org (Postfix) with ESMTP id 94D1E6E8FB for ; Thu, 12 Oct 2017 18:20:05 +0000 (UTC) In-Reply-To: <20171011152059.2394516-1-arnd@arndb.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Daniel Vetter , Jani Nikula , Sean Paul , David Airlie Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alex Deucher , Thierry Reding List-Id: dri-devel@lists.freedesktop.org --===============0802822937== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arnd Bergmann writes: > Overall, this seems good enough, so my patch removes the use of > 'timeval' from the vblank handling altogether and uses ktime_t > consistently, except for the part where we copy the data to user > space structures in the existing format. This patch is better than the portion of my patch which does the same thing as it uses the ktime APIs consistently and doesn't assume that ktime_t is in ns. Thanks much! Reviewed-by: Keith Packard =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlnfslIACgkQ2yIaaQAA ABGY2w//QRo7Q3u8kSGANzQnQr+6fuCkBAouE75dx11eNO2QeTOSdsnegYaRmcHw tDbtA2OKHFOMdKG+lgHSVyLql+FojGh2qtZs5qkODO7UhIy7GG5VggorKI3mSKqe WQFdR1SboPGPHGKhzAQNQo4Nfm/lTR3D36X+hfKPZI3ucQrAH/LJP/G5yDE0lC5A gUPmmFPuoDAROldQcRgtTbuPOFqnVEXDNtiuNelfKt8QfesVK2WArPrxAA+ywvOT qY3aUUuxYywJFdRRvjXtzScvYGxIreClk10u5cLdV+rhLdTFrZeWMrOSpFn51TKN OL1kGFN9FIyjZHMouWiKtIEnJtUDaGNGDLdH9IR9sha6ua5kRg/nINi+WGq0HSji c5d0AE/H7OH8A/K8oM/B6vB8l77D5U63+P2IWrUOObKa38vYPoJsirIjILCoTwvK M6PufkQ3IaQlSYmK+Euqos9WhHddd21AQcGA20EI6ICjTaLmUdaac3z1VHK9NPmZ MuhfBEx0YS3VZ+03HEL5m5gp/7j1vVgVoggWxvW7WSyAekf0aYIoytrazVQZ6NQ/ iYszTTvAeCquywO4UVDRqrwlh91vwIUafXaTDUzc2Uii8AOFy89qZYuByFnSLJXv dQyO/Xzs/EcfknMgvF9JK5f2qrf76fdCuNbFiTMd27zpI7xH8bQ= =v2d8 -----END PGP SIGNATURE----- --=-=-=-- --===============0802822937== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0802822937==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631AbdJLSUH (ORCPT ); Thu, 12 Oct 2017 14:20:07 -0400 Received: from home.keithp.com ([63.227.221.253]:46964 "EHLO elaine.keithp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbdJLSUF (ORCPT ); Thu, 12 Oct 2017 14:20:05 -0400 From: "Keith Packard" To: Arnd Bergmann , Daniel Vetter , Daniel Vetter , Jani Nikula , Sean Paul , David Airlie Cc: Arnd Bergmann , Ville =?utf-8?B?U3lyasOkbMOk?= , Chris Wilson , Alex Deucher , Thierry Reding , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] drm: vblank: use ktime_t instead of timeval In-Reply-To: <20171011152059.2394516-1-arnd@arndb.de> References: <20171011152059.2394516-1-arnd@arndb.de> Date: Thu, 12 Oct 2017 11:20:02 -0700 Message-ID: <87y3og5iul.fsf@keithp.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Arnd Bergmann writes: > Overall, this seems good enough, so my patch removes the use of > 'timeval' from the vblank handling altogether and uses ktime_t > consistently, except for the part where we copy the data to user > space structures in the existing format. This patch is better than the portion of my patch which does the same thing as it uses the ktime APIs consistently and doesn't assume that ktime_t is in ns. Thanks much! Reviewed-by: Keith Packard =2D-=20 =2Dkeith --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlnfslIACgkQ2yIaaQAA ABGY2w//QRo7Q3u8kSGANzQnQr+6fuCkBAouE75dx11eNO2QeTOSdsnegYaRmcHw tDbtA2OKHFOMdKG+lgHSVyLql+FojGh2qtZs5qkODO7UhIy7GG5VggorKI3mSKqe WQFdR1SboPGPHGKhzAQNQo4Nfm/lTR3D36X+hfKPZI3ucQrAH/LJP/G5yDE0lC5A gUPmmFPuoDAROldQcRgtTbuPOFqnVEXDNtiuNelfKt8QfesVK2WArPrxAA+ywvOT qY3aUUuxYywJFdRRvjXtzScvYGxIreClk10u5cLdV+rhLdTFrZeWMrOSpFn51TKN OL1kGFN9FIyjZHMouWiKtIEnJtUDaGNGDLdH9IR9sha6ua5kRg/nINi+WGq0HSji c5d0AE/H7OH8A/K8oM/B6vB8l77D5U63+P2IWrUOObKa38vYPoJsirIjILCoTwvK M6PufkQ3IaQlSYmK+Euqos9WhHddd21AQcGA20EI6ICjTaLmUdaac3z1VHK9NPmZ MuhfBEx0YS3VZ+03HEL5m5gp/7j1vVgVoggWxvW7WSyAekf0aYIoytrazVQZ6NQ/ iYszTTvAeCquywO4UVDRqrwlh91vwIUafXaTDUzc2Uii8AOFy89qZYuByFnSLJXv dQyO/Xzs/EcfknMgvF9JK5f2qrf76fdCuNbFiTMd27zpI7xH8bQ= =v2d8 -----END PGP SIGNATURE----- --=-=-=--