From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Date: Fri, 08 Sep 2017 18:08:18 +0000 Subject: Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure Message-Id: <87y3ppm5bh.fsf@anholt.net> MIME-Version: 1 Content-Type: multipart/mixed; boundary="=-=-=" List-Id: References: <20170908131704.32517-1-colin.king@canonical.com> In-Reply-To: <20170908131704.32517-1-colin.king@canonical.com> To: Colin King , David Airlie , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Colin King writes: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check removed, we may as well make > the failure path into a trivial -ENOMEM return to clean up the error > handling. > > Detected by CoverityScan CID#1339527 ("Logically dead code") Reviewed and applied. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmy3JIACgkQtdYpNtH8 nug4RhAAizQsgw7dmI9OUtxZ8ZmKlh26SGuRubNqqiba6i3Pn/SBAqcEk2FBPWHX d3FxHWiai+EEOjOUD2Isa7WCjF3WF8RRU9tClR6WEanwde8NMDNWs3t/XYObGImS s5Uwm3eatVWvuh+yBrVMcna6TNl9HWtshVnTJ5g4Hk3NRqNjNtu6bFawbapo741U WFX/ZaLzfG60RSIL4N9Ov1ywpsd/rCDxhJeBOnCVMoKdQwj1d4NDQzCXYCE0L3P0 aBdNFY5YuBWsPEzDquOE6Qw+aioXbQ7VHMQm57W2Tsi8R9cLKdE16gEXRI22zGX3 AjcsKykpCo6OkViFRYjPT6W19AClzbgjV2b4Bzp0JeixrPqW50d54JStc1MvhftB mgv8bAhNlDehsyfXpW+1YlXRD1H61BB96yMGhgEaQ5gU+MiKVRdv+hzUySx/6QCA kJ7knlraRcIkCTo7iXD9ayFKoLXeygmlGe+nm2MSD7KPWImkQ0Tmppibk79CRvQ0 GkLEyxdJawMQIqJDoOEaJHHoD6AJyDmzpzbYErKgrw3WCz8lHF1708daqdQMSkpr /V3PgkD9eGZ2DJixB1E2PMpXdAcEouyB3QOesqZ7GxNJdg1vgKF7gNf6/VqZVl+I UKN591BhB6mLRraqilknQ3MkDmXoSs2+qSpdjIcwRKQusV5b1Jg= =7ZiP -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure Date: Fri, 08 Sep 2017 11:08:18 -0700 Message-ID: <87y3ppm5bh.fsf@anholt.net> References: <20170908131704.32517-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1914799798==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 702B96EC02 for ; Fri, 8 Sep 2017 18:08:20 +0000 (UTC) In-Reply-To: <20170908131704.32517-1-colin.king@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Colin King , David Airlie , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org --===============1914799798== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Colin King writes: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check removed, we may as well make > the failure path into a trivial -ENOMEM return to clean up the error > handling. > > Detected by CoverityScan CID#1339527 ("Logically dead code") Reviewed and applied. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmy3JIACgkQtdYpNtH8 nug4RhAAizQsgw7dmI9OUtxZ8ZmKlh26SGuRubNqqiba6i3Pn/SBAqcEk2FBPWHX d3FxHWiai+EEOjOUD2Isa7WCjF3WF8RRU9tClR6WEanwde8NMDNWs3t/XYObGImS s5Uwm3eatVWvuh+yBrVMcna6TNl9HWtshVnTJ5g4Hk3NRqNjNtu6bFawbapo741U WFX/ZaLzfG60RSIL4N9Ov1ywpsd/rCDxhJeBOnCVMoKdQwj1d4NDQzCXYCE0L3P0 aBdNFY5YuBWsPEzDquOE6Qw+aioXbQ7VHMQm57W2Tsi8R9cLKdE16gEXRI22zGX3 AjcsKykpCo6OkViFRYjPT6W19AClzbgjV2b4Bzp0JeixrPqW50d54JStc1MvhftB mgv8bAhNlDehsyfXpW+1YlXRD1H61BB96yMGhgEaQ5gU+MiKVRdv+hzUySx/6QCA kJ7knlraRcIkCTo7iXD9ayFKoLXeygmlGe+nm2MSD7KPWImkQ0Tmppibk79CRvQ0 GkLEyxdJawMQIqJDoOEaJHHoD6AJyDmzpzbYErKgrw3WCz8lHF1708daqdQMSkpr /V3PgkD9eGZ2DJixB1E2PMpXdAcEouyB3QOesqZ7GxNJdg1vgKF7gNf6/VqZVl+I UKN591BhB6mLRraqilknQ3MkDmXoSs2+qSpdjIcwRKQusV5b1Jg= =7ZiP -----END PGP SIGNATURE----- --=-=-=-- --===============1914799798== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1914799798==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932735AbdIHSIX (ORCPT ); Fri, 8 Sep 2017 14:08:23 -0400 Received: from anholt.net ([50.246.234.109]:49956 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932498AbdIHSIU (ORCPT ); Fri, 8 Sep 2017 14:08:20 -0400 From: Eric Anholt To: Colin King , David Airlie , dri-devel@lists.freedesktop.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure In-Reply-To: <20170908131704.32517-1-colin.king@canonical.com> References: <20170908131704.32517-1-colin.king@canonical.com> User-Agent: Notmuch/0.22.2+1~gb0bcfaa (http://notmuchmail.org) Emacs/25.2.2 (x86_64-pc-linux-gnu) Date: Fri, 08 Sep 2017 11:08:18 -0700 Message-ID: <87y3ppm5bh.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Colin King writes: > From: Colin Ian King > > The current error handling on devm_kzalloc failures performs a non-null > check on connector. Thss check is redundant because connector is null > at that failure point. With this check removed, we may as well make > the failure path into a trivial -ENOMEM return to clean up the error > handling. > > Detected by CoverityScan CID#1339527 ("Logically dead code") Reviewed and applied. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmy3JIACgkQtdYpNtH8 nug4RhAAizQsgw7dmI9OUtxZ8ZmKlh26SGuRubNqqiba6i3Pn/SBAqcEk2FBPWHX d3FxHWiai+EEOjOUD2Isa7WCjF3WF8RRU9tClR6WEanwde8NMDNWs3t/XYObGImS s5Uwm3eatVWvuh+yBrVMcna6TNl9HWtshVnTJ5g4Hk3NRqNjNtu6bFawbapo741U WFX/ZaLzfG60RSIL4N9Ov1ywpsd/rCDxhJeBOnCVMoKdQwj1d4NDQzCXYCE0L3P0 aBdNFY5YuBWsPEzDquOE6Qw+aioXbQ7VHMQm57W2Tsi8R9cLKdE16gEXRI22zGX3 AjcsKykpCo6OkViFRYjPT6W19AClzbgjV2b4Bzp0JeixrPqW50d54JStc1MvhftB mgv8bAhNlDehsyfXpW+1YlXRD1H61BB96yMGhgEaQ5gU+MiKVRdv+hzUySx/6QCA kJ7knlraRcIkCTo7iXD9ayFKoLXeygmlGe+nm2MSD7KPWImkQ0Tmppibk79CRvQ0 GkLEyxdJawMQIqJDoOEaJHHoD6AJyDmzpzbYErKgrw3WCz8lHF1708daqdQMSkpr /V3PgkD9eGZ2DJixB1E2PMpXdAcEouyB3QOesqZ7GxNJdg1vgKF7gNf6/VqZVl+I UKN591BhB6mLRraqilknQ3MkDmXoSs2+qSpdjIcwRKQusV5b1Jg= =7ZiP -----END PGP SIGNATURE----- --=-=-=--