From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Manos Pitsidianakis <el13635@mail.ntua.gr>,
qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block <qemu-block@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed
Date: Wed, 12 Jul 2017 09:41:57 +0200 [thread overview]
Message-ID: <87y3ruaypm.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <b8bcff15-2d6c-bca9-cd44-b03ddf7d7812@redhat.com> (Eric Blake's message of "Tue, 11 Jul 2017 12:09:03 -0500")
Eric Blake <eblake@redhat.com> writes:
> On 07/11/2017 11:37 AM, Manos Pitsidianakis wrote:
>> This function is not used anywhere, so remove it.
>>
>
> Might be interesting to figure out when it WAS last used.
Yes. When I see "remove X because it's unused" during patch review, I
immediately ask "why is it unused now, and what was it used for
previously?" Ideally, the commit message answers these questions
preemptively.
> If I grepped
> correctly, it was commit 21fcf360 back in May 2012?
Yes. "fdc: simplify media change handling". I suspect that commit
broke media change for passed-through host floppy.
Its only implementation went away in commit f709623 "block: Remove host
floppy support".
Suggest
block: bdrv_media_changed() is unused, remove
The i82078 floppy device model used to call bdrv_media_changed() to
implement its media change bit when backed by a host floppy. This
went away in 21fcf36 "fdc: simplify media change handling".
Probably broke host floppy media change. Host floppy pass-through
was dropped in commit f709623. bdrv_media_changed() has never been
used for anything else. Remove it.
next prev parent reply other threads:[~2017-07-12 7:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 16:37 [Qemu-devel] [PATCH v4 0/4] block: Block driver callbacks fixes Manos Pitsidianakis
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 1/4] block: pass bdrv_* methods to bs->file by default in block filters Manos Pitsidianakis
2017-07-11 17:02 ` Eric Blake
2017-07-12 10:34 ` Stefan Hajnoczi
2017-07-13 1:34 ` Eric Blake
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 2/4] block: remove bdrv_media_changed Manos Pitsidianakis
2017-07-11 17:09 ` Eric Blake
2017-07-12 7:41 ` Markus Armbruster [this message]
2017-07-12 15:15 ` Kevin Wolf
2017-07-12 15:32 ` Manos Pitsidianakis
2017-07-12 10:35 ` Stefan Hajnoczi
2017-07-13 1:27 ` Eric Blake
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 3/4] block: remove bdrv_truncate callback in blkdebug Manos Pitsidianakis
2017-07-11 18:20 ` Eric Blake
2017-07-12 10:35 ` Stefan Hajnoczi
2017-07-11 16:37 ` [Qemu-devel] [PATCH v4 4/4] block: add default implementations for bdrv_co_get_block_status() Manos Pitsidianakis
2017-07-12 10:36 ` Stefan Hajnoczi
2017-07-12 7:49 ` [Qemu-devel] [PATCH v4 0/4] block: Block driver callbacks fixes Markus Armbruster
2017-07-12 8:10 ` Manos Pitsidianakis
2017-07-12 15:28 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3ruaypm.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=eblake@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.