Re: [PATCH] drm/i915/cnl: Don't trust VBT's alternate pin for port D for now.

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 07 Jul 2017, Rodrigo Vivi <rodrigo.vivi@gmail.com> wrote:
> patch merged to dinq. thanks for reviewing.

Did you report the VBT issue? Whenever we paper over bugs in other
components, we're sending a message it's fine. It's not.

BR,
Jani.


>
> On Thu, Jul 6, 2017 at 2:52 PM, Clint Taylor <clinton.a.taylor@intel.com> wrote:
>>
>>
>> On 07/06/2017 02:08 PM, Rodrigo Vivi wrote:
>>>
>>> Cannon Lake's VBT that is currently available for B0 stepping
>>> states that port D uses alternate pin 3 messing up with the
>>> default pin-port mapping table. Using that information we cannot
>>> get HDMI working properly. So for now we don't relly on VBT for
>>> this information.
>>>
>>> Cc: Clint Taylor <clinton.a.taylor@intel.com>
>>> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>>> ---
>>>   drivers/gpu/drm/i915/intel_bios.c | 9 +++++++++
>>>   1 file changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/i915/intel_bios.c
>>> b/drivers/gpu/drm/i915/intel_bios.c
>>> index 639d45c..82b144c 100644
>>> --- a/drivers/gpu/drm/i915/intel_bios.c
>>> +++ b/drivers/gpu/drm/i915/intel_bios.c
>>> @@ -1187,6 +1187,15 @@ static void parse_ddi_port(struct drm_i915_private
>>> *dev_priv, enum port port,
>>>         if (is_dvi) {
>>>                 info->alternate_ddc_pin = ddc_pin;
>>>   +             /*
>>> +                * All VBTs that we got so far for B Stepping has this
>>> +                * information wrong for Port D. So, let's just ignore for
>>> now.
>>> +                */
>>> +               if (IS_CNL_REVID(dev_priv, CNL_REVID_B0, CNL_REVID_B0) &&
>>> +                   port == PORT_D) {
>>> +                       info->alternate_ddc_pin = 0;
>>> +               }
>>> +
>>
>>
>> Reviewed-by: Clinton Taylor <clinton.a.taylor@intel.com>
>>
>> -Clint
>>
>>>                 sanitize_ddc_pin(dev_priv, port);
>>>         }
>>>
>>
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx