From: Kalle Valo <kvalo@codeaurora.org>
To: James Hughes <james.hughes@raspberrypi.org>
Cc: netdev@vger.kernel.org,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable
Date: Thu, 20 Apr 2017 14:31:48 +0300 [thread overview]
Message-ID: <87y3uv48nv.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20170420111651.10213-1-james.hughes@raspberrypi.org> (James Hughes's message of "Thu, 20 Apr 2017 12:16:51 +0100")
+ linux-wireless
James Hughes <james.hughes@raspberrypi.org> writes:
> The driver was adding header information to incoming skb
> without ensuring the head was uncloned and hence writable.
>
> skb_cow_head has been used to ensure they are writable, however,
> this required some changes to error handling to ensure that
> if skb_cow_head failed it was not ignored.
>
> This really needs to be reviewed by someone who is more familiar
> with this code base to ensure any deallocation of skb's is
> still correct.
>
> Signed-off-by: James Hughes <james.hughes@raspberrypi.org>
You should also CC linux-wireless, otherwise patchwork won't see it.
--
Kalle Valo
next prev parent reply other threads:[~2017-04-20 11:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 11:16 [PATCH] brcm80211: brcmfmac: Ensure that incoming skb's are writable James Hughes
2017-04-20 11:31 ` Kalle Valo [this message]
2017-04-20 12:09 ` James Hughes
2017-04-20 19:13 ` Arend van Spriel
2017-04-20 19:13 ` Arend van Spriel
2017-04-20 12:49 ` Eric Dumazet
2017-04-20 19:48 ` Arend van Spriel
2017-04-21 9:22 ` James Hughes
2017-04-21 9:22 ` James Hughes
2017-04-23 19:34 ` Arend Van Spriel
2017-04-24 8:45 ` James Hughes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3uv48nv.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=james.hughes@raspberrypi.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.