[U-Boot] [PATCH 2/2] Enable PXE boot on meson-gxbb.

[Vagrant Cascadian <vagrant@debian.org>]

On 2017-04-16, Andreas Färber wrote:
> Am 17.04.2017 um 00:01 schrieb Vagrant Cascadian:
>> Enable distro_bootcmd PXE functions on meson-gxbb systems.
>> 
>> While DHCP boot is already supported, the format is fairly u-boot
>> specific, while PXE boot supports the widely used syslinux style boot
>> configuration format.
...
>> diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
>> index c3229ea2cf..0339feaed9 100644
>> --- a/include/configs/meson-gxbb-common.h
>> +++ b/include/configs/meson-gxbb-common.h
>> @@ -41,6 +41,7 @@
>>  #define BOOT_TARGET_DEVICES(func) \
>>  	func(MMC, mmc, 0) \
>>  	func(MMC, mmc, 1) \
>> +	func(PXE, pxe, na) \
>>  	func(DHCP, dhcp, na)
>>  
>>  #include <config_distro_bootcmd.h>
>
> This should go after DHCP as discussed a while ago.

Apologies, I'm not subscribed to the list and must have missed that
discussion.


> PXE has a lengthy list of fallbacks and I fail to see what is U-Boot
> specific about DHCP.

DHCP the protocol is not at all u-boot specific, sure, but the boot
method:

#define BOOTENV_DEV_DHCP(devtypeu, devtypel, instance) \
	"bootcmd_dhcp=" \
		BOOTENV_RUN_NET_USB_START \
		BOOTENV_RUN_NET_PCI_ENUM \
		"if dhcp ${scriptaddr} ${boot_script_dhcp}; then " \
			"source ${scriptaddr}; " \
		"fi;" \
		BOOTENV_EFI_RUN_DHCP \
		"\0"

I guess I was referring to "source ${scriptaddr}; " line, which is quite
u-boot specific. I didn't realize that "DHCP" also had support for EFI
loaded over the network.

It seems unforunate that the EFI network boot is only a fallback to
loading a boot script over the network, as boot scripts and EFI boot
seem to me like two unrelated features.

When loading from MMC, I think the order goes something like EFI,
extlinux, u-boot boot scripts. With the current implementation, it
appears a similar ordering is not possible with general cases of network
boot. Which kind of reduces the consistancy for config_distro_bootcmd
for different boot methods. Hrm.

That said, I'm fine to resubmit the patch to put PXE boot after DHCP
boot...


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170417/57366bd5/attachment.sig>