From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kuoppala Subject: Re: [PATCH 2/2] drm/i915: Use wait_for_atomic_us when waiting for gt fifo Date: Thu, 06 Apr 2017 12:32:05 +0300 Message-ID: <87y3vdg9uy.fsf@gaia.fi.intel.com> References: <1491468259-5198-1-git-send-email-mika.kuoppala@intel.com> <1491468259-5198-2-git-send-email-mika.kuoppala@intel.com> <20170406091254.GY10496@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9BE726E125 for ; Thu, 6 Apr 2017 09:32:41 +0000 (UTC) In-Reply-To: <20170406091254.GY10496@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+IHdyaXRlczoKCj4gT24gVGh1 LCBBcHIgMDYsIDIwMTcgYXQgMTE6NDQ6MTlBTSArMDMwMCwgTWlrYSBLdW9wcGFsYSB3cm90ZToK Pj4gUmVwbGFjZSB0aGUgaGFuZGNyYWZ0ZXIgbG9vcCB3aGVuIGNoZWNraW5nIGZvciBmaWZvIHNs b3RzCj4+IHdpdGggYXRvbWljIHdhaXQgZm9yLiBUaGlzIGJyaW5ncyB0aGlzIHdhaXQgaW4gbGlu ZSB3aXRoCj4+IHRoZSBvdGhlciB3YWl0cyBvbiByZWdpc3RlciBhY2Nlc3MuIFdlIGFsc28gZ2V0 IGEgcmVhZGFibGUKPj4gdGltZW91dCBjb25zdHJhaW50LCBzbyBtYWtlIGl0IHRvIGZhaWwgYWZ0 ZXIgMTBtcy4KPj4gCj4+IENocmlzIHN1Z2dlc3RlZCB0aGF0IHdlIHNob3VsZCBmYWlsIHNpbGVu dGx5IGFzIHRoZSBmaWZvIGRlYnVnCj4+IGhhbmRsZXIsIG5vdyBhdHRhY2hlZCB0byB1bmNsYWlt ZWQgbW1pbyBoYW5kbGluZywgd2lsbCB0YWtlIGNhcmUgb2YgdGhlCj4+IHBvc3NpYmxlIGVycm9y cyBhdCBsYXRlciBzdGFnZS4KPj4gCj4+IE5vdGUgdGhhdCB0aGUgZGVjaXNpb24gdG8gd2FpdCB3 YXMgY2hhbmdlZCBzbyB0aGF0IHdlIGF2b2lkCj4+IGFsbG9jYXRpbmcgdGhlIGZpcnN0IHJlc2Vy dmVkIGVudHJ5LiBOb3IgZG8gd2UgcmVkdWNlIHRoZSBjb3VudAo+PiBpZiB3ZSBmYWlsIHRoZSB3 YWl0LCByZW1vdmluZyB0aGUgcG9zc2libGl0eSB0byB3cmFwIHRoZQo+PiBjb3VudCBpZiB0aGUg aHcgZmlmbyByZXR1cm5lZCB6ZXJvLgo+Cj4gT3RvaCwgd2UgZG9uJ3QgYWJvcnQgdGhlIHdyaXRl IHNvIHRoZSBzbG90IGlzIHN0aWxsIHRha2VuLiBOb3IgZG9lcyBpdAo+IHVwZGF0ZSB0aGUgbGFz dCBrbm93biBmaWZvX2NvdW50IGFsb25nIHRoYXQgcGF0aC4KPgo+IEhvd2V2ZXIsIHdlIGxlYXZl IGl0IHNldCB0byBhIHZhbHVlIHRoYXQgd2lsbCBjYXVzZSB1cyB0byByZXJlYWQgdGhlCj4gY291 bnRlciBvbiB0aGUgbmV4dCBjYWxsLCBzbyBpdCBjb21lcyBvdXQgaW4gdGhlIHdhc2guCj4KPj4g Cj4+IFJlZmVyZW5jZXM6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dp P2lkPTEwMDI0Nwo+PiBTaWduZWQtb2ZmLWJ5OiBNaWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxh QGludGVsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91bmNvcmUu YyB8IDMwICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQs IDE1IGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygtKQo+PiAKPj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfdW5jb3JlLmMKPj4gaW5kZXggYTEyOWE3My4uZGY3NDRhOCAxMDA2NDQKPj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPj4gQEAgLTI5LDYgKzI5LDcgQEAKPj4gICNpbmNsdWRl IDxsaW51eC9wbV9ydW50aW1lLmg+Cj4+ICAKPj4gICNkZWZpbmUgRk9SQ0VXQUtFX0FDS19USU1F T1VUX01TIDUwCj4+ICsjZGVmaW5lIEdUX0ZJRk9fVElNRU9VVF9NUwkgMTAKPj4gIAo+PiAgI2Rl ZmluZSBfX3Jhd19wb3N0aW5nX3JlYWQoZGV2X3ByaXZfXywgcmVnX18pICh2b2lkKV9fcmF3X2k5 MTVfcmVhZDMyKChkZXZfcHJpdl9fKSwgKHJlZ19fKSkKPj4gIAo+PiBAQCAtMTgxLDI4ICsxODIs MjcgQEAgc3RhdGljIGlubGluZSB1MzIgZmlmb19mcmVlX2VudHJpZXMoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KQo+PiAgCj4+ICBzdGF0aWMgaW50IF9fZ2VuNl9ndF93YWl0X2Zv cl9maWZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gIHsKPj4gLQlpbnQg cmV0ID0gMDsKPj4gKwl1MzIgbjsKPj4gIAo+PiAgCS8qIE9uIFZMViwgRklGTyB3aWxsIGJlIHNo YXJlZCBieSBib3RoIFNXIGFuZCBIVy4KPj4gIAkgKiBTbywgd2UgbmVlZCB0byByZWFkIHRoZSBG UkVFX0VOVFJJRVMgZXZlcnl0aW1lICovCj4+ICAJaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYp KQo+PiAtCQlkZXZfcHJpdi0+dW5jb3JlLmZpZm9fY291bnQgPSBmaWZvX2ZyZWVfZW50cmllcyhk ZXZfcHJpdik7Cj4+IC0KPj4gLQlpZiAoZGV2X3ByaXYtPnVuY29yZS5maWZvX2NvdW50IDwgR1Rf RklGT19OVU1fUkVTRVJWRURfRU5UUklFUykgewo+PiAtCQlpbnQgbG9vcCA9IDUwMDsKPj4gLQkJ dTMyIGZpZm8gPSBmaWZvX2ZyZWVfZW50cmllcyhkZXZfcHJpdik7Cj4+IC0KPj4gLQkJd2hpbGUg KGZpZm8gPD0gR1RfRklGT19OVU1fUkVTRVJWRURfRU5UUklFUyAmJiBsb29wLS0pIHsKPj4gLQkJ CXVkZWxheSgxMCk7Cj4+IC0JCQlmaWZvID0gZmlmb19mcmVlX2VudHJpZXMoZGV2X3ByaXYpOwo+ PiArCQluID0gZmlmb19mcmVlX2VudHJpZXMoZGV2X3ByaXYpOwo+PiArCWVsc2UKPj4gKwkJbiA9 IGRldl9wcml2LT51bmNvcmUuZmlmb19jb3VudDsKPj4gKwo+PiArCWlmIChuIDw9IEdUX0ZJRk9f TlVNX1JFU0VSVkVEX0VOVFJJRVMpIHsKPj4gKwkJaWYgKHdhaXRfZm9yX2F0b21pYygobiA9IGZp Zm9fZnJlZV9lbnRyaWVzKGRldl9wcml2KSkgPgo+PiArCQkJCSAgICBHVF9GSUZPX05VTV9SRVNF UlZFRF9FTlRSSUVTLAo+PiArCQkJCSAgICBHVF9GSUZPX1RJTUVPVVRfTVMpKSB7Cj4+ICsJCQlE Uk1fREVCVUcoIkdUX0ZJRk8gdGltZW91dCwgZW50cmllczogJXUsIHVuY2xhaW1lZDogJWRcbiIs IG4sCj4+ICsJCQkJICBpbnRlbF91bmNvcmVfdW5jbGFpbWVkX21taW8oZGV2X3ByaXYpKTsKPgo+ IFdoYXQncyB0aGUgY29ubmVjdGlvbiBoZXJlIGJldHdlZW4gdW5jbGFpbWVkIG1taW8gYW5kIHRo ZSBmaWZvIGNvdW50Pwo+IGkuZS4gd2hhdCBpbmZvcm1hdGlvbiBkbyB3ZSBnbGVhbj8gRXNwY2lh bGx5IGFzIHRoaXMgaW5mb3JtYXRpb24gaXMgcGFydAo+IG9mIHRoZSBnZW5lcmljIG1taW8gZnJh bWV3b3JrIGFscmVhZHkuCj4KClRvIHRyaWdnZXIgZmlmb2RiZyBjaGVjayBhbmQgY2xlYW4uIEFu ZCB0byBnZXQgYSB0cmFjZSBmcm9tIHRoaXMgZXhhY3Qgc3BvdC4KU28gdGhpcyBiYXR0bGVzIGFn YWluc3QgdGhlIGNvbW1pdCBtZXNzYWdlIHRvIGxlYXZlIHRoZSB3YXJuIGludG8gdGhlCnVuY2xh aW1lZCBoYW5kbGluZy4gSSB3aWxsIHJlbW92ZSBpdC4KCi1NaWthCgo+PiArCQkJcmV0dXJuIC1F QlVTWTsKPj4gIAkJfQo+PiAtCQlpZiAoV0FSTl9PTihsb29wIDwgMCAmJiBmaWZvIDw9IEdUX0ZJ Rk9fTlVNX1JFU0VSVkVEX0VOVFJJRVMpKQo+PiAtCQkJKytyZXQ7Cj4+IC0JCWRldl9wcml2LT51 bmNvcmUuZmlmb19jb3VudCA9IGZpZm87Cj4+ICAJfQo+PiAtCWRldl9wcml2LT51bmNvcmUuZmlm b19jb3VudC0tOwo+Cj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2ls c29uLmNvLnVrPgo+IC1DaHJpcwo+Cj4gLS0gCj4gQ2hyaXMgV2lsc29uLCBJbnRlbCBPcGVuIFNv dXJjZSBUZWNobm9sb2d5IENlbnRyZQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK