From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cqF4E-0001fp-0T for qemu-devel@nongnu.org; Tue, 21 Mar 2017 04:22:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cqF4A-0001AU-Rj for qemu-devel@nongnu.org; Tue, 21 Mar 2017 04:22:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33828) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cqF4A-00019L-JX for qemu-devel@nongnu.org; Tue, 21 Mar 2017 04:22:54 -0400 From: Juan Quintela In-Reply-To: <20170321022243.29453-1-fanc.fnst@cn.fujitsu.com> (Chao Fan's message of "Tue, 21 Mar 2017 10:22:43 +0800") References: <20170321022243.29453-1-fanc.fnst@cn.fujitsu.com> Reply-To: quintela@redhat.com Date: Tue, 21 Mar 2017 09:22:52 +0100 Message-ID: <87y3vz82eb.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2] Add page-size to output in 'info migrate' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chao Fan Cc: qemu-devel@nongnu.org, dgilbert@redhat.com, eblake@redhat.com, armbru@redhat.com, berrange@redhat.com, caoj.fnst@cn.fujitsu.com, douly.fnst@cn.fujitsu.com, maozy.fnst@cn.fujitsu.com, Li Zhijian Chao Fan wrote: > The number of dirty pages outputed in 'pages' in the command > 'info migrate', so add page-size to calculate the number of dirty > pages in bytes. > > Signed-off-by: Chao Fan > Signed-off-by: Li Zhijian > > --- > v2: fix the grammar in qapi-schema.json [Eric Blake] Hi If you see my RAMState series, you can see that things have moved a lot here, I added this to my current series: (there is a rename of qemu_target_page_bits() to qemu_target_page_size() in the series). If you like it, I can leave it that way there. Thanks, Juan. commit 1944568bd8cdf912b3bf231bbc3c66071fde9f58 Author: Chao Fan Date: Tue Mar 21 10:22:43 2017 +0800 Add page-size to output in 'info migrate' The number of dirty pages outputed in 'pages' in the command 'info migrate', so add page-size to calculate the number of dirty pages in bytes. Signed-off-by: Chao Fan Signed-off-by: Li Zhijian Signed-off-by: Juan Quintela diff --git a/hmp.c b/hmp.c index edb8970..be75e71 100644 --- a/hmp.c +++ b/hmp.c @@ -215,6 +215,9 @@ void hmp_info_migrate(Monitor *mon, const QDict *qdict) info->ram->normal_bytes >> 10); monitor_printf(mon, "dirty sync count: %" PRIu64 "\n", info->ram->dirty_sync_count); + monitor_printf(mon, "page size: %" PRIu64 " kbytes\n", + info->ram->page_size >> 10); + if (info->ram->dirty_pages_rate) { monitor_printf(mon, "dirty pages rate: %" PRIu64 " pages\n", info->ram->dirty_pages_rate); diff --git a/migration/migration.c b/migration/migration.c index 92c3c6b..fc19ba7 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -650,6 +650,7 @@ static void populate_ram_info(MigrationInfo *info, MigrationState *s) info->ram->mbps = s->mbps; info->ram->dirty_sync_count = ram_dirty_sync_count(); info->ram->postcopy_requests = ram_postcopy_requests(); + info->ram->page_size = qemu_target_page_size(); if (s->state != MIGRATION_STATUS_COMPLETED) { info->ram->remaining = ram_bytes_remaining(); diff --git a/qapi-schema.json b/qapi-schema.json index 68a4327..c7ec62c 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -598,6 +598,9 @@ # @postcopy-requests: The number of page requests received from the destination # (since 2.7) # +# @page-size: The number of bytes per page for the various page-based +# statistics (since 2.10) +# # Since: 0.14.0 ## { 'struct': 'MigrationStats', @@ -605,7 +608,7 @@ 'duplicate': 'int', 'skipped': 'int', 'normal': 'int', 'normal-bytes': 'int', 'dirty-pages-rate' : 'int', 'mbps' : 'number', 'dirty-sync-count' : 'int', - 'postcopy-requests' : 'int' } } + 'postcopy-requests' : 'int', 'page-size' : 'int' } } ## # @XBZRLECacheStats: