From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]) by merlin.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cb1rg-0001Wb-0e for ath10k@lists.infradead.org; Tue, 07 Feb 2017 09:15:08 +0000 From: "Valo, Kalle" Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Date: Tue, 7 Feb 2017 09:14:42 +0000 Message-ID: <87y3xi4b28.fsf@qca.qualcomm.com> References: <1486030773-30600-1-git-send-email-amadeusz.slawinski@tieto.com> In-Reply-To: (Adrian Chadd's message of "Thu, 2 Feb 2017 08:17:00 -0800") Content-Language: en-US MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Adrian Chadd Cc: "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , =?iso-8859-2?Q?Amadeusz_S=B3awi=F1ski?= , "ath10k@lists.infradead.org" , Linux Kernel Mailing List Adrian Chadd writes: > Removing this method makes the diff to FreeBSD larger, as "vif" in > FreeBSD is a different pointer. > > (Yes, I have ath10k on freebsd working and I'd like to find a way to > reduce the diff moving forward.) I don't like this "(void *) vif->drv_priv" style that much either but apparently it's commonly used in Linux wireless code and already parts of ath10k. So this patch just unifies the coding style. -- Kalle Valo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:36068 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbdBGJOp (ORCPT ); Tue, 7 Feb 2017 04:14:45 -0500 From: "Valo, Kalle" To: Adrian Chadd CC: =?iso-8859-2?Q?Amadeusz_S=B3awi=F1ski?= , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "Linux Kernel Mailing List" , "ath10k@lists.infradead.org" Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Date: Tue, 7 Feb 2017 09:14:42 +0000 Message-ID: <87y3xi4b28.fsf@qca.qualcomm.com> (sfid-20170207_101513_931839_4090A1A0) References: <1486030773-30600-1-git-send-email-amadeusz.slawinski@tieto.com> In-Reply-To: (Adrian Chadd's message of "Thu, 2 Feb 2017 08:17:00 -0800") Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Adrian Chadd writes: > Removing this method makes the diff to FreeBSD larger, as "vif" in > FreeBSD is a different pointer. > > (Yes, I have ath10k on freebsd working and I'd like to find a way to > reduce the diff moving forward.) I don't like this "(void *) vif->drv_priv" style that much either but apparently it's commonly used in Linux wireless code and already parts of ath10k. So this patch just unifies the coding style. --=20 Kalle Valo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753514AbdBGJOv (ORCPT ); Tue, 7 Feb 2017 04:14:51 -0500 Received: from wolverine01.qualcomm.com ([199.106.114.254]:36068 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752035AbdBGJOp (ORCPT ); Tue, 7 Feb 2017 04:14:45 -0500 X-IronPort-AV: E=Sophos;i="5.33,345,1477983600"; d="scan'208";a="260821869" X-IronPort-AV: E=McAfee;i="5800,7501,8431"; a="861884915" From: "Valo, Kalle" To: Adrian Chadd CC: =?iso-8859-2?Q?Amadeusz_S=B3awi=F1ski?= , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "Linux Kernel Mailing List" , "ath10k@lists.infradead.org" Subject: Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Thread-Topic: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif() Thread-Index: AQHSgSKdXhLW1W5rb0ahmbyXBxBFIw== Date: Tue, 7 Feb 2017 09:14:42 +0000 Message-ID: <87y3xi4b28.fsf@qca.qualcomm.com> References: <1486030773-30600-1-git-send-email-amadeusz.slawinski@tieto.com> In-Reply-To: (Adrian Chadd's message of "Thu, 2 Feb 2017 08:17:00 -0800") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v179Et8q026043 Adrian Chadd writes: > Removing this method makes the diff to FreeBSD larger, as "vif" in > FreeBSD is a different pointer. > > (Yes, I have ath10k on freebsd working and I'd like to find a way to > reduce the diff moving forward.) I don't like this "(void *) vif->drv_priv" style that much either but apparently it's commonly used in Linux wireless code and already parts of ath10k. So this patch just unifies the coding style. -- Kalle Valo