From: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Kristoffer Haugsbakk <kristoffer.haugsbakk@gmail.com>,
Philip Oakley <philipoakley@iee.org>,
git@vger.kernel.org
Subject: Re: [PATCH 1/4] doc: add articles (grammar)
Date: Tue, 13 Dec 2016 22:34:22 +0100 [thread overview]
Message-ID: <87y3zjikdd.fsf@gmail.com> (raw)
In-Reply-To: <xmqqoa0f4s2v.fsf@gitster.mtv.corp.google.com>
Junio C Hamano writes:
> I was planning to merge all four from you as-is to 'next' today,
> though. Should I wait?
I'll definitely defer to whatever you think is best. I guess it depends
on whether you are interested in Philip Oakley's suggestions. I sent
those emails to inform about what I intended to do in the next round, if
it got to that point, since I haven't tried to contribute to such an
organised project before. So I was informing about my assumptions about
how to deal with "looks good to me"-kinds of feedback.
So for my part, I'm happy with iterating on this (perhaps just adding
the two "acks", or also replying to the suggestions), or just merging it
as-is.
--
Kristoffer Haugsbakk
next prev parent reply other threads:[~2016-12-13 21:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 15:51 [PATCH 0/4] doc: fixes to gitcore-tutorial.txt Kristoffer Haugsbakk
2016-12-09 15:51 ` [PATCH 1/4] doc: add articles (grammar) Kristoffer Haugsbakk
2016-12-10 20:28 ` Philip Oakley
2016-12-13 13:05 ` Kristoffer Haugsbakk
2016-12-13 18:11 ` Junio C Hamano
2016-12-13 21:34 ` Kristoffer Haugsbakk [this message]
2016-12-09 15:51 ` [PATCH 2/4] doc: add verb in front of command to run Kristoffer Haugsbakk
2016-12-10 20:48 ` Philip Oakley
2016-12-09 15:51 ` [PATCH 3/4] doc: make the intent of sentence clearer Kristoffer Haugsbakk
2016-12-10 20:52 ` Philip Oakley
2016-12-13 13:23 ` Kristoffer Haugsbakk
2016-12-09 15:51 ` [PATCH 4/4] doc: omit needless "for" Kristoffer Haugsbakk
2016-12-11 13:04 ` Philip Oakley
2016-12-11 14:08 ` Philip Oakley
2016-12-09 23:13 ` [PATCH 0/4] doc: fixes to gitcore-tutorial.txt Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3zjikdd.fsf@gmail.com \
--to=kristoffer.haugsbakk@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=philipoakley@iee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.