All of lore.kernel.org
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Nikolay Borisov <n.borisov.lkml@gmail.com>
Cc: Nikolay Borisov <kernel@kyup.com>,
	containers@lists.linux-foundation.org, jack@suse.cz,
	linux-kernel@vger.kernel.org, serge@hallyn.com
Subject: Re: [PATCH v2] inotify: Convert to using per-namespace limits
Date: Fri, 09 Dec 2016 15:50:38 +1300	[thread overview]
Message-ID: <87y3zpdddt.fsf@xmission.com> (raw)
In-Reply-To: <e86b3a4f-51d5-ea61-93f3-883fe2dbcf34@gmail.com> (Nikolay Borisov's message of "Thu, 8 Dec 2016 08:58:31 +0200")

Nikolay Borisov <n.borisov.lkml@gmail.com> writes:

> On  8.12.2016 03:40, Eric W. Biederman wrote:
>> Nikolay Borisov <kernel@kyup.com> writes:
>> 
>>> Gentle ping, now that rc1 has shipped and Jan's sysctl concern hopefully
>>> resolved.
>> 
>> After getting slowed down by some fixes I am now taking a hard look at
>> your patch in the hopes of merging it.
>> 
>> Did you happen to see the kbuild test roboot boot failures and did you
>> happen to look into what caused them?  I have just skimmed them and it
>> appears to be related to your patch.
>
> I saw them in the beginning but they did look like a generic memory
> corruption and I believe at the time those patches were submitted there
> was a lingering memory corruption hitting various patches. Thus I didn't
> think it was related to my patches. I've since left my work so been
> taking a bit of time off and haven't looked really hard, so those
> patches have been kind of lingering.

Fair enough.  I generally give the kbuild folks the benefit of the doubt
as they try hard to avoid false positives.

> But now that you mention it I will try and take a second look to see
> what might cause the memory corruption? Is there a way to force 0day to
> re-run them to see whether the failure was indeed caused by my patches
> or were intermittent?

Good question.  I will push the patch to my for-testing branch and see
if any problems show up.

That plus I will read through your patch and make certain I can
understand what is going on.

Eric

  parent reply	other threads:[~2016-12-09  2:53 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 10:46 [PATCH] inotify: Convert to using per-namespace limits Nikolay Borisov
2016-10-07 10:46 ` Nikolay Borisov
2016-10-07 18:14 ` Eric W. Biederman
     [not found]   ` <8737k86n7q.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-10-10  6:44     ` Nikolay Borisov
2016-10-10  6:44       ` Nikolay Borisov
     [not found]       ` <57FB38C3.9090803-6AxghH7DbtA@public.gmane.org>
2016-10-10 16:40         ` Jan Kara
2016-10-10 16:40           ` Jan Kara
     [not found]           ` <20161010164046.GG24081-4I4JzKEfoa/jFM9bn6wA6Q@public.gmane.org>
2016-10-10 20:49             ` Eric W. Biederman
2016-10-10 20:49               ` Eric W. Biederman
     [not found]               ` <87eg3o3p6l.fsf-JOvCrm2gF+uungPnsOpG7nhyD016LWXt@public.gmane.org>
2016-10-10 21:54                 ` Nikolay Borisov
2016-10-10 21:54               ` Nikolay Borisov
     [not found]                 ` <CAJFSNy7q39M_=fZ2nOzPEhLcQ3o6B6ELFE-jsbkRuxsst1G1JQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-10 22:39                   ` Eric W. Biederman
2016-10-10 22:39                     ` Eric W. Biederman
2016-10-11  7:36             ` [PATCH v2] " Nikolay Borisov
2016-10-11  7:36               ` Nikolay Borisov
     [not found]               ` <1476171382-11911-1-git-send-email-kernel-6AxghH7DbtA@public.gmane.org>
2016-10-14  2:31                 ` [lkp] [inotify] 464e1236c3: BUG kmalloc-512 (Not tainted): Freepointer corrupt kernel test robot
2016-10-24  6:47                 ` [PATCH v2] inotify: Convert to using per-namespace limits Nikolay Borisov
2016-10-24  6:47                   ` Nikolay Borisov
     [not found]                   ` <674564a4-ff05-b4d6-4a98-8cfc2e609325-6AxghH7DbtA@public.gmane.org>
2016-10-27 15:46                     ` Eric W. Biederman
2016-12-08  1:40                     ` Eric W. Biederman
2016-12-08  1:40                       ` Eric W. Biederman
     [not found]                       ` <87twafci52.fsf-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
2016-12-08  6:58                         ` Nikolay Borisov
2016-12-08  6:58                           ` Nikolay Borisov
     [not found]                           ` <e86b3a4f-51d5-ea61-93f3-883fe2dbcf34-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-08  8:14                             ` Nikolay Borisov
2016-12-08  8:14                               ` Nikolay Borisov
     [not found]                               ` <100ecab5-6656-9ed6-c0f4-b9c97eae506a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-12-09  5:38                                 ` Eric W. Biederman
2016-12-09  5:38                                   ` Eric W. Biederman
2016-12-09  2:50                             ` Eric W. Biederman
2016-12-09  2:50                           ` Eric W. Biederman [this message]
2016-10-27 15:46                   ` Eric W. Biederman
2016-10-24  7:48                 ` Jan Kara
2016-10-24  7:48                   ` Jan Kara
2016-11-14  6:04                 ` Serge E. Hallyn
2016-11-14  6:04                   ` Serge E. Hallyn
2016-10-14  2:31               ` [inotify] 464e1236c3: BUG kmalloc-512 (Not tainted): Freepointer corrupt kernel test robot
2016-10-14  2:31                 ` [lkp] " kernel test robot
     [not found] ` <1475837161-4626-1-git-send-email-kernel-6AxghH7DbtA@public.gmane.org>
2016-10-07 18:14   ` [PATCH] inotify: Convert to using per-namespace limits Eric W. Biederman
2016-10-09  5:55   ` [lkp] [inotify] 1109954e99: BUG kmalloc-512 (Not tainted): Freepointer corrupt kernel test robot
2016-10-09  5:55     ` kernel test robot
2016-10-09  5:55     ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3zpdddt.fsf@xmission.com \
    --to=ebiederm@xmission.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=jack@suse.cz \
    --cc=kernel@kyup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n.borisov.lkml@gmail.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.