All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs
Date: Wed, 23 Nov 2016 16:22:08 +0200	[thread overview]
Message-ID: <87y40auvhr.fsf@intel.com> (raw)
In-Reply-To: <20161123140417.18538-1-chris@chris-wilson.co.uk>

On Wed, 23 Nov 2016, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> +#define drm_fb_helper_for_each_connector(fbh, i__) \
> +	for (({lockdep_assert_held(&(fbh)->dev->mode_config.mutex); 1;}), \
> +	     i__ = 0; i__ < (fbh)->connector_count; i__++)

No comments on the substance, but just curious, why is that "1;"
required there? Or is it?

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2016-11-23 14:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 14:04 [PATCH 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs Chris Wilson
2016-11-23 14:04 ` [PATCH 2/3] drm: Pull together probe + setup for drm_fb_helper Chris Wilson
2016-11-28  7:55   ` Daniel Vetter
2016-11-23 14:04 ` [PATCH 3/3] drm: Protect fb_helper list manipulation with a mutex Chris Wilson
2016-11-28  7:55   ` Daniel Vetter
2016-11-28  8:38     ` Chris Wilson
2016-11-28 14:16       ` Daniel Vetter
2016-11-23 14:22 ` Jani Nikula [this message]
2016-11-23 15:47 ` ✓ Fi.CI.BAT: success for series starting with [1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs Patchwork
2016-11-28  7:26 ` [PATCH 1/3] " Daniel Vetter
2016-11-28 14:59   ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y40auvhr.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.