From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33565)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1byeqi-00067F-M6
	for qemu-devel@nongnu.org; Mon, 24 Oct 2016 08:59:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1byeqd-0008D2-92
	for qemu-devel@nongnu.org; Mon, 24 Oct 2016 08:59:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34172)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <armbru@redhat.com>) id 1byeqd-0008Cy-3N
	for qemu-devel@nongnu.org; Mon, 24 Oct 2016 08:59:27 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <20161020103636.22228-1-dgilbert@redhat.com>
Date: Mon, 24 Oct 2016 14:59:24 +0200
In-Reply-To: <20161020103636.22228-1-dgilbert@redhat.com> (David Alan
	Gilbert's message of "Thu, 20 Oct 2016 11:36:34 +0100")
Message-ID: <87y41dewcz.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 0/2] Silence test-vmstate errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, peter.maydell@linaro.org

"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> writes:

> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> In a1771070e7 I added an error message during migration loading
> so you could see the field that failed to load.
> Unfortunately this triggers during the expected-failure case
> testing in tests/test-vmstate.
>
> This silences that error by providing a dummy monitor pointer
> that doesn't output anything and then selecting it around
> the noisy part of the test.
>
> (I couldn't find anywhere better than libqtest.h for the declaration
> but stubs doesn't have it's own header; is it worth creating one
> just for that?)

Maybe.  Always hard to say for the first one.

You could simply put it in monitor.h.  When somebody uses it outside
tests, linking fails.  If that bothers you, feel free to implement a
silent non-stub monitor.

With Eric's spelling fixes squashed in, and with or without my
suggestion on PATCH 2:
Reviewed-by: Markus Armbruster <armbru@redhat.com>