From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48744)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bmaxT-0007Zr-DJ
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 02:24:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bmaxP-0007fL-CB
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 02:24:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:53584)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bmaxP-0007el-5e
	for qemu-devel@nongnu.org; Wed, 21 Sep 2016 02:24:35 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1474391326-871-1-git-send-email-felipe@nutanix.com>
	<000301d213c7$7142f980$53c8ec80$@ru>
Date: Wed, 21 Sep 2016 08:24:32 +0200
In-Reply-To: <000301d213c7$7142f980$53c8ec80$@ru> (Pavel Dovgalyuk's message
	of "Wed, 21 Sep 2016 08:17:24 +0300")
Message-ID: <87y42l93dr.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with
 -Werror=unused-result
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgalyuk <dovgaluk@ispras.ru>
Cc: 'Felipe Franciosi' <felipe@nutanix.com>, 'Pavel Dovgalyuk' <Pavel.Dovgaluk@ispras.ru>, 'Eric Blake' <eblake@redhat.com>, qemu-devel@nongnu.org

"Pavel Dovgalyuk" <dovgaluk@ispras.ru> writes:

>> From: Felipe Franciosi [mailto:felipe@nutanix.com]
>> If compiling with -Werror=unused-result, replay-internal.c won't build
>> due to a call to fwrite() where the returned value is ignored. A simple
>> cast to (void) is not sufficient on recent GCCs, so this fixes it.
>> 
>> Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
>> ---
>>  replay/replay-internal.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/replay/replay-internal.c b/replay/replay-internal.c
>> index 5835e8d..6978d76 100644
>> --- a/replay/replay-internal.c
>> +++ b/replay/replay-internal.c
>> @@ -65,7 +65,7 @@ void replay_put_array(const uint8_t *buf, size_t size)
>>  {
>>      if (replay_file) {
>>          replay_put_dword(size);
>> -        fwrite(buf, 1, size, replay_file);
>> +        (void)(fwrite(buf, 1, size, replay_file)+1);
>>      }
>>  }
>
> This looks very weird.
> I think it would be better to check the return value and stop
> the simulation in case of error.

Ignoring errors is wrong more often than not.  Whether it's wrong in
this case I can't say.  What I can say is 1. the commit message needs to
explain *why* the error can be ignored, and 2. the way you ignore the
error is scandalously ugly :)  You say gcc doesn't honor the traditional
cast to void anymore.  What's the exact error message you see?