All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DT: kirkwood: Fix Openblock A6 external GPIO pins
Date: Fri, 26 Aug 2016 11:17:06 +0200	[thread overview]
Message-ID: <87y43jj3e5.fsf@free-electrons.com> (raw)
In-Reply-To: <20160815145104.14135-1-jason@lakedaemon.net> (Jason Cooper's message of "Mon, 15 Aug 2016 14:51:04 +0000")

Hi Jason,
 
 On lun., ao?t 15 2016, Jason Cooper <jason@lakedaemon.net> wrote:

> By assigning the pin hog to the pinctrl node, we correctly configure the
> MPPs.  However, they are not available to userspace.
>
> Fix this by assigning the hogs to the gpio node.
>
> After this, the following works as expected:
>
>   # echo 28 >/sys/class/gpio/export
>   # echo low >/sys/class/gpio/gpio28/direction
>
> Signed-off-by: Jason Cooper <jason@lakedaemon.net>

Applied on mvebu/dt with Reviewed-by flag from Andrew and I changed the
title to "ARM: dts: kirkwood: ..."

Thanks,

Gregory
> ---
> After sleeping on it a night, I decided to leave the dip switches alone.
>
>  arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> index 0db0e3edc88f..94e49f32d5f9 100644
> --- a/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> +++ b/arch/arm/boot/dts/kirkwood-openblocks_a6.dts
> @@ -41,7 +41,7 @@
>  		};
>  
>  		pinctrl: pin-controller at 10000 {
> -			pinctrl-0 = <&pmx_dip_switches &pmx_gpio_header>;
> +			pinctrl-0 = <&pmx_dip_switches>;
>  			pinctrl-names = "default";
>  
>  			pmx_uart0: pmx-uart0 {
> @@ -174,3 +174,10 @@
>  		phy-handle = <&ethphy0>;
>  	};
>  };
> +
> +&gpio0 {
> +	status = "okay";
> +
> +	pinctrl-0 = <&pmx_gpio_header>;
> +	pinctrl-names = "default";
> +};
> -- 
> 2.9.2
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

      parent reply	other threads:[~2016-08-26  9:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-15  1:35 [RFC PATCH] DT: kirkwood: Fix Openblock A6 external GPIO pins Jason Cooper
2016-08-15 14:51 ` [PATCH] " Jason Cooper
2016-08-17 14:46   ` Andrew Lunn
2016-08-26  9:17   ` Gregory CLEMENT [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y43jj3e5.fsf@free-electrons.com \
    --to=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.