From: Andreas Schwab <schwab@linux-m68k.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Eli Barzilay <eli@barzilay.org>,
git@vger.kernel.org
Subject: Re: Minor bug: git config ignores empty sections
Date: Mon, 15 Aug 2016 20:54:16 +0200 [thread overview]
Message-ID: <87y43x3lt3.fsf@linux-m68k.org> (raw)
In-Reply-To: <xmqqh9alhoor.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 15 Aug 2016 11:28:20 -0700")
On Aug 15 2016, Junio C Hamano <gitster@pobox.com> wrote:
> If we were to remove the section header at this point, we should
> be removing the comment two out of three cases.
>
> - if it is about section.key, it should go when section.key goes.
> - if it is about section, it should go when section goes.
> - if it is a more generic comment about this configuration file,
> it should stay.
The comment may not be related to the surrounding keys, but just a
commented-out config key that you want to keep around for reference.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2016-08-15 18:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 1:29 Minor bug: git config ignores empty sections Eli Barzilay
2016-08-15 12:09 ` Jeff King
2016-08-15 17:34 ` Andreas Schwab
2016-08-15 18:09 ` Jeff King
2016-08-15 18:28 ` Junio C Hamano
2016-08-15 18:54 ` Andreas Schwab [this message]
2016-08-15 18:55 ` Jeff King
2016-08-15 20:49 ` Junio C Hamano
2016-08-16 4:06 ` Eli Barzilay
2016-08-16 12:36 ` Jeff King
2016-08-21 17:09 ` Jakub Narębski
2016-08-15 17:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y43x3lt3.fsf@linux-m68k.org \
--to=schwab@linux-m68k.org \
--cc=eli@barzilay.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.