From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP4J2-0006ER-Vh for qemu-devel@nongnu.org; Mon, 18 Jul 2016 04:53:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bP4Iz-0008Ns-RH for qemu-devel@nongnu.org; Mon, 18 Jul 2016 04:53:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bP4Iz-0008Nm-JB for qemu-devel@nongnu.org; Mon, 18 Jul 2016 04:53:37 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C6F5C05AA40 for ; Mon, 18 Jul 2016 08:53:36 +0000 (UTC) From: Markus Armbruster References: <1468594858-26889-1-git-send-email-prasanna.kalever@redhat.com> <1468594858-26889-4-git-send-email-prasanna.kalever@redhat.com> Date: Mon, 18 Jul 2016 10:53:34 +0200 In-Reply-To: <1468594858-26889-4-git-send-email-prasanna.kalever@redhat.com> (Prasanna Kumar Kalever's message of "Fri, 15 Jul 2016 20:30:56 +0530") Message-ID: <87y44z2upd.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v19 3/5] block/gluster: remove rdma transport List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever Cc: qemu-devel@nongnu.org, vbellur@redhat.com, jcody@redhat.com, rtalur@redhat.com Prasanna Kumar Kalever writes: > gluster volfile server fetch happens through unix and/or tcp, it doesn't > support volfile fetch over rdma, hence removing the dead code > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 35 +---------------------------------- > 1 file changed, 1 insertion(+), 34 deletions(-) > > diff --git a/block/gluster.c b/block/gluster.c > index 40ee852..59f77bb 100644 > --- a/block/gluster.c > +++ b/block/gluster.c > @@ -134,8 +134,7 @@ static int parse_volume_options(GlusterConf *gconf, char *path) > * > * 'transport' specifies the transport type used to connect to gluster > * management daemon (glusterd). Valid transport types are > - * tcp, unix and rdma. If a transport type isn't specified, then tcp > - * type is assumed. > + * tcp, unix. If a transport type isn't specified, then tcp type is assumed. > * > * 'host' specifies the host where the volume file specification for > * the given volume resides. This can be either hostname, ipv4 address > @@ -162,7 +161,6 @@ static int parse_volume_options(GlusterConf *gconf, char *path) > * file=gluster+tcp://[1:2:3:4:5:6:7:8]:24007/testvol/dir/a.img > * file=gluster+tcp://host.domain.com:24007/testvol/dir/a.img > * file=gluster+unix:///testvol/dir/a.img?socket=/tmp/glusterd.socket > - * file=gluster+rdma://1.2.3.4:24007/testvol/a.img > */ > static int qemu_gluster_parseuri(GlusterConf *gconf, const char *filename) > { > @@ -184,8 +182,6 @@ static int qemu_gluster_parseuri(GlusterConf *gconf, const char *filename) > } else if (!strcmp(uri->scheme, "gluster+unix")) { > gconf->transport = g_strdup("unix"); Outside this patch's scope: string literals would be just fine for gconf->transport. > is_unix = true; > - } else if (!strcmp(uri->scheme, "gluster+rdma")) { > - gconf->transport = g_strdup("rdma"); > } else { > ret = -EINVAL; > goto out; > @@ -1048,37 +1044,8 @@ static BlockDriver bdrv_gluster_unix = { > .create_opts = &qemu_gluster_create_opts, > }; > > -static BlockDriver bdrv_gluster_rdma = { > - .format_name = "gluster", > - .protocol_name = "gluster+rdma", > - .instance_size = sizeof(BDRVGlusterState), > - .bdrv_needs_filename = true, > - .bdrv_file_open = qemu_gluster_open, > - .bdrv_reopen_prepare = qemu_gluster_reopen_prepare, > - .bdrv_reopen_commit = qemu_gluster_reopen_commit, > - .bdrv_reopen_abort = qemu_gluster_reopen_abort, > - .bdrv_close = qemu_gluster_close, > - .bdrv_create = qemu_gluster_create, > - .bdrv_getlength = qemu_gluster_getlength, > - .bdrv_get_allocated_file_size = qemu_gluster_allocated_file_size, > - .bdrv_truncate = qemu_gluster_truncate, > - .bdrv_co_readv = qemu_gluster_co_readv, > - .bdrv_co_writev = qemu_gluster_co_writev, > - .bdrv_co_flush_to_disk = qemu_gluster_co_flush_to_disk, > - .bdrv_has_zero_init = qemu_gluster_has_zero_init, > -#ifdef CONFIG_GLUSTERFS_DISCARD > - .bdrv_co_discard = qemu_gluster_co_discard, > -#endif > -#ifdef CONFIG_GLUSTERFS_ZEROFILL > - .bdrv_co_pwrite_zeroes = qemu_gluster_co_pwrite_zeroes, > -#endif > - .bdrv_co_get_block_status = qemu_gluster_co_get_block_status, > - .create_opts = &qemu_gluster_create_opts, > -}; > - > static void bdrv_gluster_init(void) > { > - bdrv_register(&bdrv_gluster_rdma); > bdrv_register(&bdrv_gluster_unix); > bdrv_register(&bdrv_gluster_tcp); > bdrv_register(&bdrv_gluster); This is fine if gluster+rdma never actually worked. I tried to find out at https://github.com/gluster/glusterfs/blob/master/api/src/glfs.h. Transport rdma is mentioned there. Does it work?