From: Markus Armbruster <armbru@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc
Date: Wed, 03 Feb 2016 08:01:41 +0100 [thread overview]
Message-ID: <87y4b25lbe.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <56B126E7.3090704@redhat.com> (Eric Blake's message of "Tue, 2 Feb 2016 15:00:07 -0700")
Eric Blake <eblake@redhat.com> writes:
> On 02/02/2016 01:04 PM, Markus Armbruster wrote:
>> Eric Blake <eblake@redhat.com> writes:
>>
>>> Commit 86f4b687 broke compilation on sparc, which has a preprocessor
>>> pollution of '#define sparc 1'. Treat it the same way as we do for
>>> the pollution with 'unix', so that QMP remains backwards compatible
>>> and only the C code needs to use the alternative 'q_sparc' spelling.
>>>
>>> CC: Peter Maydell <peter.maydell@linaro.org>
>>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>> ---
>>>
>>> Done as a followup to the same style of patch for MIPS; or we could
>>> squash this into one patch.
>>
>> Applied to qapi-next squashed:
>>
>> qapi: Fix compilation failure on MIPS and SPARC
>>
>> Commit 86f4b687 broke compilation on MIPS and SPARC, which have a
>> preprocessor pollution of '#define mips 1' and '#define space 1',
>
> s/space/sparc/
>
>> respectively. Treat it the same way as we do for the pollution with
>> 'unix', so that QMP remains backwards compatible and only the C code
>> needs to use the alternative 'q_mips' spelling.
>>
>> CC: James Hogan <james.hogan@imgtec.com>
>> CC: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>> Tested-by: James Hogan <james.hogan@imgtec.com>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>>
Fixed up and pushed again. Thanks!
prev parent reply other threads:[~2016-02-03 7:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 19:05 [Qemu-devel] [PATCH] qapi: Fix compilation failure on sparc Eric Blake
2016-02-02 20:04 ` Markus Armbruster
2016-02-02 22:00 ` Eric Blake
2016-02-03 7:01 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4b25lbe.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=crosthwaite.peter@gmail.com \
--cc=eblake@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.