From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54976) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQWSZ-0005Hh-EZ for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:37:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aQWSW-0001qV-71 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:37:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aQWSW-0001qH-22 for qemu-devel@nongnu.org; Tue, 02 Feb 2016 03:37:12 -0500 From: Markus Armbruster References: <1454343639-9020-1-git-send-email-marcandre.lureau@redhat.com> Date: Tue, 02 Feb 2016 09:37:09 +0100 In-Reply-To: <1454343639-9020-1-git-send-email-marcandre.lureau@redhat.com> (marcandre lureau's message of "Mon, 1 Feb 2016 17:20:31 +0100") Message-ID: <87y4b3tsne.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 0/8] ivshmem: test msi=off, fix regressions, remove CharDriver List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com Cc: claudio.fontana@huawei.com, qemu-devel@nongnu.org marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > This is a ivshmem series with various bits: > - add a test for msi=3Doff regression (the fix is included in the series > but was sent separatly to cc -stable) > - get rid of CharDriver usage for eventfd & fix regression introduced > by d0d7708ba by Daniel Berrange > - fix some test leaks > - simplify event callback > > v1->v2: after Markus Armbruster review, > - add a few comments to commit messages > - fix !msi with nvectors=3D=3D0 regression > - comment in commit message that the status register is set to 1 when > an interrupt occurs, following the ivshmem specification > - found out that getting rid of CharDriver also fixed regression from > d0d7708ba > - rebase The two nits I found seem harmless enough to me to sneak into the pull request rather than post a full v3 first. Use your judgement. Thanks!