From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3l4u-0002Fc-TC for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:34:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a3l4u-0005Gk-8R for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:34:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a3l4u-0005GZ-3y for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:34:44 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id BF074A3D22 for ; Tue, 1 Dec 2015 13:34:43 +0000 (UTC) From: Markus Armbruster References: <1448975034-1314-1-git-send-email-armbru@redhat.com> <565D9CF2.10300@redhat.com> Date: Tue, 01 Dec 2015 14:34:41 +0100 In-Reply-To: <565D9CF2.10300@redhat.com> (Paolo Bonzini's message of "Tue, 1 Dec 2015 14:13:22 +0100") Message-ID: <87y4decmxa.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH] coverity: Model g_poll() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org Paolo Bonzini writes: > On 01/12/2015 14:03, Markus Armbruster wrote: >> Coverity now reports two more CHECKED_RETURN: >> >> * qemu-char.c:1248: Should be fixed by Paolo's "qemu-char: retry >> g_poll on EINTR". >> >> * migration/qemu-file-unix.c:75: if g_poll() fails, we retry sending >> before the file descriptor is ready. Errors other than EINTR are >> mostly theoretical, though. > > EINTR is harmless too here, you'll just get another EAGAIN. I'll mark > it as Intentional / Fix Required in the coverity dashboard. I posted a cleanup patch anyway. Migration maintainers can decide whether they want it or not.