From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmVwM-00016V-G9 for qemu-devel@nongnu.org; Wed, 14 Oct 2015 19:58:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmVwJ-0001cM-As for qemu-devel@nongnu.org; Wed, 14 Oct 2015 19:58:38 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:48079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmVwJ-0001cA-1U for qemu-devel@nongnu.org; Wed, 14 Oct 2015 19:58:35 -0400 From: OGAWA Hirofumi References: <87k2qp8yxv.fsf@mail.parknet.co.jp> <87fv1d8ywp.fsf@mail.parknet.co.jp> <87bnc18yvw.fsf_-_@mail.parknet.co.jp> <1444837495.4467.29.camel@redhat.com> Date: Thu, 15 Oct 2015 08:58:29 +0900 In-Reply-To: <1444837495.4467.29.camel@redhat.com> (Gerd Hoffmann's message of "Wed, 14 Oct 2015 17:44:55 +0200") Message-ID: <87y4f56lzu.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 2/3] ui/curses: Support line graphics chars on -curses mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org Gerd Hoffmann writes: > On Mi, 2015-10-14 at 20:37 +0900, OGAWA Hirofumi wrote: >> This converts vga code to curses code in console_write_bh(). >> >> With this changes, we can see line graphics (for example, dialog uses) >> correctly. > > But it breaks line graphics in vga text mode on gtk I suspect? vga_to_curses[] is filled by curses_setup(). So if no -curses option, I think it should have no change to behavior. (BTW, there is no common section like kernel in qemu build, right? i.e. no need initializer to global value.) Thanks. -- OGAWA Hirofumi