All of lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Francoise <romain@orebokech.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Tahsin Erdogan <tahsin@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block: Make CFQ default to IOPS mode on SSDs
Date: Wed, 10 Jun 2015 08:44:56 +0200	[thread overview]
Message-ID: <87y4jsjc47.fsf@orebokech.com> (raw)
In-Reply-To: <55772585.30707@kernel.dk> (Jens Axboe's message of "Tue, 09 Jun 2015 11:42:29 -0600")

Hi,

On Tue, Jun 09, 2015 at 11:42:29AM -0600, Jens Axboe wrote:
> There are a few options to handle this. The attached might work, not
> tested at all. Basically it adds an io sched registration hook, that is
> called when we are adding the disk on the queue. Non-rotational
> detection should be done at that point.
>
> Does that work for you?

Yep, that works perfectly in my (admittedly limited) testing; slice_idle
is correctly set to 0 on non-rotational devices and keeps its default
value of 8 otherwise. Feel free to add my Tested-by.

Thanks!

  parent reply	other threads:[~2015-06-10  6:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 20:55 [PATCH] block: Make CFQ default to IOPS mode on SSDs Tahsin Erdogan
2015-05-27 20:14 ` Tahsin Erdogan
2015-06-05 22:58   ` Tahsin Erdogan
2015-06-06  1:20     ` Jens Axboe
2015-06-09 10:18 ` Romain Francoise
2015-06-09 17:42   ` Jens Axboe
2015-06-09 21:54     ` Tahsin Erdogan
2015-06-10  6:44     ` Romain Francoise [this message]
2015-06-10 14:03       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4jsjc47.fsf@orebokech.com \
    --to=romain@orebokech.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tahsin@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.