All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Liu Ying <Ying.Liu@freescale.com>, dri-devel@lists.freedesktop.org
Cc: daniel.vetter@ffwll.ch
Subject: Re: [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format
Date: Tue, 12 May 2015 16:23:51 +0300	[thread overview]
Message-ID: <87y4ku2al4.fsf@intel.com> (raw)
In-Reply-To: <1423805119-32008-1-git-send-email-Ying.Liu@freescale.com>


I guess this fell between the cracks.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


On Fri, 13 Feb 2015, Liu Ying <Ying.Liu@freescale.com> wrote:
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> v9->v9.5:
>  * Add kernel-doc for the new helper function to address Daniel Vetter's
>    comment.
>
> v8->v9:
>  * Rebase onto the imx-drm/next branch of Philipp Zabel's open git repository.
>
> v7->v8:
>  * None.
>
> v6->v7:
>  * None.
>
> v5->v6:
>  * Address the over 80 characters in one line warning reported by the
>    checkpatch.pl script.
>
> v4->v5:
>  * None.
>
> v3->v4:
>  * None.
>
> v2->v3:
>  * None.
>
> v1->v2:
>  * Thierry Reding suggested that the mipi_dsi_pixel_format_to_bpp() function
>    could be placed at the common DRM MIPI DSI driver.
>    This patch is newly added.
>
>  include/drm/drm_mipi_dsi.h | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
> index f1d8d0d..cabc910 100644
> --- a/include/drm/drm_mipi_dsi.h
> +++ b/include/drm/drm_mipi_dsi.h
> @@ -163,6 +163,28 @@ static inline struct mipi_dsi_device *to_mipi_dsi_device(struct device *dev)
>  	return container_of(dev, struct mipi_dsi_device, dev);
>  }
>  
> +/**
> + * mipi_dsi_pixel_format_to_bpp() - get bits per pixel for a mipi dsi
> + *    pixel format
> + * @fmt: mipi dsi pixel format
> + *
> + * Return: The bits per pixel value for the mipi dsi pixel format on success or
> + *    a negative error code on failure.
> + */
> +static inline int mipi_dsi_pixel_format_to_bpp(enum mipi_dsi_pixel_format fmt)
> +{
> +	switch (fmt) {
> +	case MIPI_DSI_FMT_RGB888:
> +	case MIPI_DSI_FMT_RGB666:
> +		return 24;
> +	case MIPI_DSI_FMT_RGB666_PACKED:
> +		return 18;
> +	case MIPI_DSI_FMT_RGB565:
> +		return 16;
> +	}
> +	return -EINVAL;
> +}
> +
>  struct mipi_dsi_device *of_find_mipi_dsi_device_by_node(struct device_node *np);
>  int mipi_dsi_attach(struct mipi_dsi_device *dsi);
>  int mipi_dsi_detach(struct mipi_dsi_device *dsi);
> -- 
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-05-12 13:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13  5:25 [PATCH RFC v9.5 09/20] drm/dsi: Add a helper to get bits per pixel of MIPI DSI pixel format Liu Ying
2015-02-13  5:25 ` Liu Ying
2015-02-13  5:25 ` Liu Ying
2015-05-12 13:23 ` Jani Nikula [this message]
2015-05-12 13:36 ` Thierry Reding
2015-05-12 13:36   ` Thierry Reding
2015-05-12 13:36   ` Thierry Reding
2015-05-14  2:10   ` Liu Ying
2015-05-14  2:10     ` Liu Ying
2015-05-14  2:10     ` Liu Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4ku2al4.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=Ying.Liu@freescale.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.