From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752880AbbCWOyW (ORCPT ); Mon, 23 Mar 2015 10:54:22 -0400 Received: from e28smtp07.in.ibm.com ([122.248.162.7]:51999 "EHLO e28smtp07.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752850AbbCWOyQ (ORCPT ); Mon, 23 Mar 2015 10:54:16 -0400 From: "Aneesh Kumar K.V" To: Taesoo Kim , ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net, v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Cc: taesoo@gatech.edu, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu, Taesoo Kim Subject: Re: [PATCH 1/1] 9p: correctly check empty xattr key In-Reply-To: <1426824116-22920-1-git-send-email-tsgatesv@gmail.com> References: <1426824116-22920-1-git-send-email-tsgatesv@gmail.com> User-Agent: Notmuch/0.19+30~gd241a48 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Mon, 23 Mar 2015 20:24:07 +0530 Message-ID: <87y4mnn4s0.fsf@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15032314-0025-0000-0000-000003EADA9C Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Taesoo Kim writes: > When xattr name (key) is empty (""), correctly return -EINVAL > error. Not sure how previous xattr_set_acl() performs with > any xattr key for get/set(). Did you test this ? > > Signed-off-by: Taesoo Kim > --- > fs/9p/acl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/9p/acl.c b/fs/9p/acl.c > index 8482f2d..295bf25 100644 > --- a/fs/9p/acl.c > +++ b/fs/9p/acl.c > @@ -237,7 +237,7 @@ static int v9fs_xattr_get_acl(struct dentry *dentry, const char *name, > struct posix_acl *acl; > int error; > > - if (strcmp(name, "") != 0) > + if (strcmp(name, "") == 0) > return -EINVAL; We get the name in get_acl callback after xattr_resolve_name. ie, the value of name is name = strcmp_prefix(passed_name, "system.posix_acl_access"); We should find that name "" isn't it ? > > v9ses = v9fs_dentry2v9ses(dentry); > @@ -287,7 +287,7 @@ static int v9fs_xattr_set_acl(struct dentry *dentry, const char *name, > struct v9fs_session_info *v9ses; > struct inode *inode = dentry->d_inode; > > - if (strcmp(name, "") != 0) > + if (strcmp(name, "") == 0) > return -EINVAL; > > v9ses = v9fs_dentry2v9ses(dentry); > -- > 2.3.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/