From: Jani Nikula <jani.nikula@linux.intel.com>
To: ville.syrjala@linux.intel.com, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/5] drm/i915: Handle DP_AUX_I2C_WRITE_STATUS_UPDATE
Date: Wed, 18 Mar 2015 13:52:21 +0200 [thread overview]
Message-ID: <87y4muo74a.fsf@intel.com> (raw)
In-Reply-To: <1426263201-10637-3-git-send-email-ville.syrjala@linux.intel.com>
On Fri, 13 Mar 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> When we get an i2c defer or short ack for i2c-over-aux write we need
> to switch to WRITE_STATUS_UPDATE to poll for the completion of the
> original request.
>
> i915 doesn't try to interpret wht request type apart from separating
> reads from writes, and so we should be able to treat this the same as
> a normal i2c write.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Probably needs a refresh due to context change due to my short writes
patch though.
> ---
> drivers/gpu/drm/i915/intel_dp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 33d5877..aed5f26 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -956,6 +956,7 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
> switch (msg->request & ~DP_AUX_I2C_MOT) {
> case DP_AUX_NATIVE_WRITE:
> case DP_AUX_I2C_WRITE:
> + case DP_AUX_I2C_WRITE_STATUS_UPDATE:
> txsize = msg->size ? HEADER_SIZE + msg->size : BARE_ADDRESS_SIZE;
> rxsize = 1;
>
> --
> 2.0.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-18 11:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 16:13 [PATCH 0/5] drm/dp: i2c-over-aux short write support ville.syrjala
2015-03-13 16:13 ` [PATCH 1/5] drm/dp: s/I2C_STATUS/I2C_WRITE_STATUS_UPDATE/ ville.syrjala
2015-03-18 11:49 ` [Intel-gfx] " Jani Nikula
2015-03-13 16:13 ` [PATCH 2/5] drm/i915: Handle DP_AUX_I2C_WRITE_STATUS_UPDATE ville.syrjala
2015-03-18 11:52 ` Jani Nikula [this message]
2015-03-13 16:13 ` [PATCH 3/5] drm/radeon: " ville.syrjala
2015-03-13 16:13 ` [PATCH 4/5] drm/tegra: Handle I2C_WRITE_STATUS_UPDATE for address only writes ville.syrjala
2015-03-13 16:13 ` [PATCH 5/5] drm/dp: Use I2C_WRITE_STATUS_UPDATE to drain partial I2C_WRITE requests ville.syrjala
2015-03-14 5:02 ` shuang.he
2015-03-17 15:22 ` Jani Nikula
2015-03-19 9:21 ` Ville Syrjälä
2015-03-18 12:05 ` Jani Nikula
[not found] ` <CADnq5_NZyw-vY761GyrDapWjdY94Jk-2+6uoj906yG3BPWBsNQ@mail.gmail.com>
2015-03-18 13:26 ` Fwd: [PATCH 0/5] drm/dp: i2c-over-aux short write support Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4muo74a.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.