From: Yoshinori Sato <ysato@users.sourceforge.jp>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v4 03/15] h8300: Exception and Interrupt handling
Date: Sun, 22 Feb 2015 15:20:11 +0900 [thread overview]
Message-ID: <87y4nq31t0.wl-ysato@users.sourceforge.jp> (raw)
In-Reply-To: <20150221095804.GW29656@ZenIV.linux.org.uk>
At Sat, 21 Feb 2015 09:58:04 +0000,
Al Viro wrote:
>
> On Sat, Feb 21, 2015 at 04:53:47PM +0900, Yoshinori Sato wrote:
>
> > +resume_userspace:
> > + andc #0xbf,ccr
> > + mov.l sp,er4
> > + and.w #0xe000,r4 /* er4 <- current thread info */
> > + mov.l @(TI_FLAGS:16,er4),er1
> > + and.l #_TIF_WORK_MASK,er1
> > + beq restore_all:8
> > +work_pending:
> > + btst #TIF_NEED_RESCHED,r1l
> > + bne work_resched:8
> > + /* work notifysig */
> > + mov.l sp,er0
> > + subs #4,er0 /* er0: pt_regs */
> > + jsr @do_notify_resume
> > + bra restore_all:8
>
> This is wrong. You really need to handle multiple signals; it ought to
> reload er1 and recheck it (or just branch to resume_userspace instead)
OK.
Fixed.
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
next prev parent reply other threads:[~2015-02-22 6:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-21 7:53 [PATCH v4 00/15] Revert h8300 architecture Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 01/15] h8300: Assembly headers Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 02/15] h8300: UAPI headers Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 03/15] h8300: Exception and Interrupt handling Yoshinori Sato
2015-02-21 9:58 ` Al Viro
2015-02-22 6:20 ` Yoshinori Sato [this message]
2015-02-21 7:53 ` [PATCH v4 04/15] h8300: kernel booting Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 05/15] h8300: Process and signal Yoshinori Sato
2015-02-21 9:51 ` Al Viro
2015-02-22 6:21 ` Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 06/15] h8300: CPU depend helpers Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 07/15] h8300: miscellaneous functions Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 08/15] h8300: Memory management Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 09/15] h8300: library functions Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 10/15] h8300: Build scripts Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 11/15] h8300: clock driver Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 12/15] h8300: clocksource Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 13/15] h8300: configs Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 14/15] serial: Add h8300 Yoshinori Sato
2015-02-21 7:53 ` [PATCH v4 15/15] Add ELF machine Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4nq31t0.wl-ysato@users.sourceforge.jp \
--to=ysato@users.sourceforge.jp \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.