From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@linaro.org (Kevin Hilman) Date: Tue, 17 Dec 2013 16:38:18 -0800 Subject: [PATCH v12 05/08] ARM: hi3xxx: add smp support In-Reply-To: <1386748497-11290-6-git-send-email-haojian.zhuang@gmail.com> (Haojian Zhuang's message of "Wed, 11 Dec 2013 15:54:54 +0800") References: <1386748497-11290-1-git-send-email-haojian.zhuang@gmail.com> <1386748497-11290-6-git-send-email-haojian.zhuang@gmail.com> Message-ID: <87y53jm1s5.fsf@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Haojian Zhuang writes: > From: Zhangfei Gao > > Enable SMP support on hi3xxx platform > > Signed-off-by: Zhangfei Gao > Tested-by: Zhang Mingjun > Tested-by: Li Xin > Signed-off-by: Haojian Zhuang This one has checkpatch errors too: ERROR: do not initialise statics to 0 or NULL #267: FILE: arch/arm/mach-hi3xxx/platsmp.c:20: +static void __iomem *ctrl_base = NULL; ERROR: space prohibited before that close parenthesis ')' #282: FILE: arch/arm/mach-hi3xxx/platsmp.c:35: + return readl_relaxed(ctrl_base + ((cpu - 1 ) << 2)); I fixed these up locally too, but my generosity is running out. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v12 05/08] ARM: hi3xxx: add smp support Date: Tue, 17 Dec 2013 16:38:18 -0800 Message-ID: <87y53jm1s5.fsf@linaro.org> References: <1386748497-11290-1-git-send-email-haojian.zhuang@gmail.com> <1386748497-11290-6-git-send-email-haojian.zhuang@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1386748497-11290-6-git-send-email-haojian.zhuang-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> (Haojian Zhuang's message of "Wed, 11 Dec 2013 15:54:54 +0800") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Haojian Zhuang Cc: olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org, arnd-r2nGTMty4D4@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, patches-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, Zhangfei Gao List-Id: devicetree@vger.kernel.org Haojian Zhuang writes: > From: Zhangfei Gao > > Enable SMP support on hi3xxx platform > > Signed-off-by: Zhangfei Gao > Tested-by: Zhang Mingjun > Tested-by: Li Xin > Signed-off-by: Haojian Zhuang This one has checkpatch errors too: ERROR: do not initialise statics to 0 or NULL #267: FILE: arch/arm/mach-hi3xxx/platsmp.c:20: +static void __iomem *ctrl_base = NULL; ERROR: space prohibited before that close parenthesis ')' #282: FILE: arch/arm/mach-hi3xxx/platsmp.c:35: + return readl_relaxed(ctrl_base + ((cpu - 1 ) << 2)); I fixed these up locally too, but my generosity is running out. Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html