Re: [PATCH 1/2] perf tools: Compare dso's also when comparing symbols

[Namhyung Kim <namhyung@kernel.org>]

On Tue, 15 Oct 2013 08:08:29 +0200, Ingo Molnar wrote:
> * Namhyung Kim <namhyung@kernel.org> wrote:
>
>> From: Namhyung Kim <namhyung.kim@lge.com>
>> 
>> Linus reported that sometimes 'perf report -s symbol' exits without any 
>> message on TUI.  David and Jiri found that it's because it failed to add 
>> a hist entry due to an invalid symbol length.
>
> Btw., 'exit without any messages' is something that should be fixed 
> separately as well I suspect.

Sure.  I believe acme is gonna work on it. :)

>
>>  static int64_t
>>  sort__sym_cmp(struct hist_entry *left, struct hist_entry *right)
>>  {
>> +	int64_t ret;
>> +
>
> Btw., this file should go back to u64/s64 like the kernel and most of perf 
> does. (A few int64_t uses slipped into other places as well, I suspect 
> they should be fixed.)

Okay, will send a separate patch for the fix.

Thanks,
Namhyung