From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: inverted brightness quirk for HP 2000 Notebook Date: Wed, 28 Aug 2013 21:23:46 +0300 Message-ID: <87y57ld68d.fsf@intel.com> References: <1377711509-2211-1-git-send-email-rodrigo.vivi@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 2431DE7DB1 for ; Wed, 28 Aug 2013 11:26:16 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Rodrigo Vivi Cc: intel-gfx List-Id: intel-gfx@lists.freedesktop.org On Wed, 28 Aug 2013, Daniel Vetter wrote: > On Wed, Aug 28, 2013 at 7:38 PM, Rodrigo Vivi wrote: >> 01.org forum: https://01.org/linuxgraphics/node/199 >> >> Slot: 00:02.0 >> Class: VGA compatible controller [0300] >> Vendor: Intel Corporation [8086] >> Device: 2nd Generation Core Processor Family Integrated Graphics Controller [0106] >> SVendor: Hewlett-Packard Company [103c] >> SDevice: Device [1854] >> Rev: 09 >> >> Reported-by: Laurent Chardon >> Cc: Jani Nikula >> Signed-off-by: Rodrigo Vivi > > All the inverted brightness machines we've seen have been gen4 and > Acer/Packard Bell. I suspect there's something amiss in our backlight > handling and at least for current platforms I don't want to merge > quirks before we've reasonably proven that we really need them. Which > means someone should show that Windows has specific code for this HP > laptop first ... Agreed. I'd be wary of adding inverted backlight quirks for anything other than gen4 Acers (or their other brands). > One thing I remember is that there's a linearization table in the vbt > somewhere, maybe that does the trick. Or we simply race our driver > against something in the firmware and inverting the brightness here > cures that. If you get the reporter to dump the i915_opregion file from debugfs, I could check the table. Cheers, Jani. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > +41 (0) 79 365 57 48 - http://blog.ffwll.ch