From: Anthony Liguori <aliguori@us.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE
Date: Tue, 09 Jul 2013 16:24:02 -0500 [thread overview]
Message-ID: <87y59f1l71.fsf@codemonkey.ws> (raw)
In-Reply-To: <CAFEAcA_Os8pxPo2jFpbMNYakhuJdosoi2ZWCqF1XDifmgRRxnQ@mail.gmail.com>
Peter Maydell <peter.maydell@linaro.org> writes:
> On 9 July 2013 21:45, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> Michael Tokarev <mjt@tls.msk.ru> writes:
>>> 09.07.2013 22:37, Anthony Liguori wrote:
>>>> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic: assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 0)
>>>> GTester: last random seed: R02S25031265f05e4d41efcf758c9ef6043b
>>>
>>> Sure, because the test is bogus.
>>
>> No, it's a guest ABI. You cannot change the guest ABI.
>
> Why the heck are we telling the guest that the user
> specified -nographic anyhow? It's a dumb guest ABI...
I believe OpenBIOS uses this to determine if it should display messages
on serial or on the graphic display.
It's actually a useful ABI in that regard.
Regards,
Anthony Liguori
>> -display none != -nographic.
>>
>> nographic gives you -display none plus a stdio serial port (with muxing
>> magic).
>>
>> -display none should not imply stdio serial port. The vc goes to a
>> dummy display. That's a major semantic difference.
>
> None of these semantics have changed AFAICT.
>
> -- PMM
next prev parent reply other threads:[~2013-07-09 21:24 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-19 12:34 [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE Michael Tokarev
2013-06-28 10:38 ` Michael Tokarev
2013-06-28 11:24 ` Peter Maydell
2013-06-28 11:29 ` Michael Tokarev
2013-06-28 11:34 ` Peter Maydell
2013-06-28 11:43 ` Michael Tokarev
2013-06-28 11:50 ` Peter Maydell
2013-06-28 12:05 ` Paolo Bonzini
2013-06-28 11:45 ` Andreas Färber
2013-06-28 11:50 ` Michael Tokarev
2013-06-28 11:55 ` Peter Maydell
2013-06-28 12:05 ` Michael Tokarev
2013-06-28 12:06 ` Paolo Bonzini
2013-06-28 12:09 ` Peter Maydell
2013-06-28 11:56 ` Andreas Färber
2013-06-28 12:05 ` Andreas Färber
2013-06-28 12:11 ` Paolo Bonzini
2013-07-09 18:37 ` Anthony Liguori
2013-07-09 19:00 ` Michael Tokarev
2013-07-09 20:45 ` Anthony Liguori
2013-07-09 21:18 ` Peter Maydell
2013-07-09 21:24 ` Anthony Liguori [this message]
2013-07-09 21:36 ` Peter Maydell
2013-07-09 22:03 ` Anthony Liguori
2013-07-16 11:10 ` Michael Tokarev
2013-07-10 4:45 ` Michael Tokarev
2013-07-10 5:08 ` Michael Tokarev
2013-07-16 11:35 ` Peter Maydell
2013-07-10 4:18 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y59f1l71.fsf@codemonkey.ws \
--to=aliguori@us.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.