From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38933)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1UvsZ4-0006Rm-Hu
	for qemu-devel@nongnu.org; Sun, 07 Jul 2013 13:15:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1UvsZ2-0008Tb-WB
	for qemu-devel@nongnu.org; Sun, 07 Jul 2013 13:15:58 -0400
Received: from e28smtp06.in.ibm.com ([122.248.162.6]:47346)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aneesh.kumar@linux.vnet.ibm.com>) id 1UvsZ2-0008TC-5T
	for qemu-devel@nongnu.org; Sun, 07 Jul 2013 13:15:56 -0400
Received: from /spool/local
	by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <aneesh.kumar@linux.vnet.ibm.com>;
	Sun, 7 Jul 2013 22:37:57 +0530
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by d28dlp02.in.ibm.com (Postfix) with ESMTP id E768E3940043
	for <qemu-devel@nongnu.org>; Sun,  7 Jul 2013 22:45:47 +0530 (IST)
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	r67HFkba20643842
	for <qemu-devel@nongnu.org>; Sun, 7 Jul 2013 22:45:46 +0530
Received: from d28av02.in.ibm.com (loopback [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	r67HFnPr010420
	for <qemu-devel@nongnu.org>; Mon, 8 Jul 2013 03:15:49 +1000
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
In-Reply-To: <51D33999.6000806@weilnetz.de>
References: <1371376960-18192-1-git-send-email-sw@weilnetz.de>
	<51D33999.6000806@weilnetz.de>
Date: Sun, 07 Jul 2013 22:45:49 +0530
Message-ID: <87y59i9tq2.fsf@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Stefan Weil <sw@weilnetz.de> writes:

> Am 16.06.2013 12:02, schrieb Stefan Weil:
>> This leak was reported by cppcheck.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>  fsdev/qemu-fsdev.c |    2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c
>> index 6eaf36d..ccfec13 100644
>> --- a/fsdev/qemu-fsdev.c
>> +++ b/fsdev/qemu-fsdev.c
>> @@ -76,6 +76,8 @@ int qemu_fsdev_add(QemuOpts *opts)
>>  
>>      if (fsle->fse.ops->parse_opts) {
>>          if (fsle->fse.ops->parse_opts(opts, &fsle->fse)) {
>> +            g_free(fsle->fse.fsdev_id);
>> +            g_free(fsle);
>>              return -1;
>>          }
>>      }
>
> Ping?

Both the error path result in Qemu terminating right ? Do we really care
about free in those case ?

-aneesh