From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UphTL-00063m-EV for qemu-devel@nongnu.org; Thu, 20 Jun 2013 12:12:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UphTG-0003wi-Mw for qemu-devel@nongnu.org; Thu, 20 Jun 2013 12:12:31 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:49086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UphTG-0003wb-Hp for qemu-devel@nongnu.org; Thu, 20 Jun 2013 12:12:26 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 20 Jun 2013 12:12:26 -0400 From: Anthony Liguori In-Reply-To: <51C3251B.6050800@suse.de> References: <1371674435-14973-1-git-send-email-aliguori@us.ibm.com> <1371674435-14973-8-git-send-email-aliguori@us.ibm.com> <51C3251B.6050800@suse.de> Date: Thu, 20 Jun 2013 11:10:36 -0500 Message-ID: <87y5a4bw5f.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 07/12] spapr-rtas: add CPU argument to RTAS calls List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?utf-8?Q?F=C3=A4rber?= Cc: Alexey Kardashevskiy , Paul Mackerras , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alex Graf Andreas F=C3=A4rber writes: > Am 19.06.2013 22:40, schrieb Anthony Liguori: >> RTAS is a hypervisor provided binary blob that a guest loads and >> calls into to execute certain functions. It's similar to the >> vsyscall page in Linux or the short lived VMCI paravirt interface >> from VMware. >>=20 >> The QEMU implementation of the RTAS blob is simply a passthrough >> that proxies all RTAS calls to the hypervisor via an hypercall. >>=20 >> While we pass a CPU argument for hypercall handling in QEMU, we >> don't pass it for RTAS calls. Since some RTAs calls require > > "RTAS" > >> making hypercalls (normally RTAS is implemented as guest code) we >> have nasty hacks to allow that. > > Where are such nasty hacks being removed? I just see the cpu argument > propagated mostly unused throughout code. [PATCH 08/12] spapr-rtas: use hypercall interface and remove special vty interfaces Regards, Anthony Liguori > >>=20 >> Add a CPU argument to RTAS call handling so we can more easily >> invoke hypercalls just as guest code would. >>=20 >> Signed-off-by: Anthony Liguori >> --- >> hw/nvram/spapr_nvram.c | 4 ++-- >> hw/ppc/spapr_events.c | 2 +- >> hw/ppc/spapr_hcall.c | 2 +- >> hw/ppc/spapr_pci.c | 13 +++++++------ >> hw/ppc/spapr_rtas.c | 21 +++++++++++---------- >> hw/ppc/spapr_vio.c | 6 ++++-- >> hw/ppc/xics.c | 12 ++++++++---- >> include/hw/ppc/spapr.h | 5 +++-- >> 8 files changed, 37 insertions(+), 28 deletions(-) > > Otherwise, > > Reviewed-by: Andreas F=C3=A4rber > > Andreas > > --=20 > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3= =BCrnberg